Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images_to_samples.py (hdf5s) --> data_to_tiles.py: add gdal library in conda #216

Closed
remtav opened this issue Dec 15, 2021 · 3 comments · Fixed by #522
Closed

Images_to_samples.py (hdf5s) --> data_to_tiles.py: add gdal library in conda #216

remtav opened this issue Dec 15, 2021 · 3 comments · Fixed by #522

Comments

@remtav
Copy link
Collaborator

remtav commented Dec 15, 2021

Onboarding solaris requires GDL to use gdal as a python library (not just from the OS). This will require us to update environment.yml to create a functional conda env with this new dependency.
For context, see #215

@ymoisan
Copy link
Contributor

ymoisan commented Dec 16, 2021

I gather we'll keep using rasterio right ? If so, we should investigate how to better use rasterio's gdal bindings and avoid potential issues.

@remtav
Copy link
Collaborator Author

remtav commented Dec 16, 2021

I gather we'll keep using rasterio right ? If so, we should investigate how to better use rasterio's gdal bindings and avoid potential issues.

Thank for raising this flag. Digging deeper into the solaris utilities that will be necessary for us, we can easily remove gdal as a python dependency. Solaris basically implemented the use of gdal datasets side by side with rasterio dataset. 2 examples (only 2 scripts use from osgeo import gdal):
https://github.com/remtav/geo-deep-learning/blob/solaris_tiling/solaris_gdl/raster/image.py#L31
https://github.com/remtav/geo-deep-learning/blob/solaris_tiling/solaris_gdl/utils/geo.py#L151

If we decide to remove all implementations of gdal.dataset, etc., we can remove gdal as a dependency and close this issue.

@remtav
Copy link
Collaborator Author

remtav commented Feb 7, 2022

Solaris v0.5 will drop the gdal dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants