Jd/ntp bugfix #14
Merged
Jd/ntp bugfix #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/hydro_generation.jl
Outdated
| @@ -571,9 +580,9 @@ function PSI.add_constraints!( | |||
| resolution = PSI.get_resolution(container) | |||
| fraction_of_hour = Dates.value(Dates.Minute(resolution)) / PSI.MINUTES_IN_HOUR | |||
| names = [PSY.get_name(x) for x in devices] | |||
| initial_conditions = PSI.get_initial_condition(container, InitialEnergyLevelDown(), V) | |||
| initial_conditions = PSI.get_initial_condition(container, InitialHydroEnergyLevelDown(), V) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| initial_conditions = PSI.get_initial_condition(container, InitialHydroEnergyLevelDown(), V) | |
| initial_conditions = | |
| PSI.get_initial_condition(container, InitialHydroEnergyLevelDown(), V) |
src/hydro_generation.jl
Outdated
| @@ -764,23 +775,25 @@ | |||
| return | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
src/hydro_generation.jl
Outdated
Comment on lines
876
to
877
| var_val = | ||
| PSI.get_variable_value(store, EnergyVariableUp(), PSI.get_component_type(ic)) | ||
| PSI.get_variable_value(store, HydroEnergyVariableUp(), PSI.get_component_type(ic)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| var_val = | |
| PSI.get_variable_value(store, EnergyVariableUp(), PSI.get_component_type(ic)) | |
| PSI.get_variable_value(store, HydroEnergyVariableUp(), PSI.get_component_type(ic)) | |
| var_val = PSI.get_variable_value( | |
| store, | |
| HydroEnergyVariableUp(), | |
| PSI.get_component_type(ic), | |
| ) |
src/hydrogeneration_constructor.jl
Outdated
Comment on lines
1209
to
1210
| PSI.add_variables!(container, HydroEnergyVariableUp, devices, HydroDispatchPumpedStorage()) | ||
| PSI.add_variables!(container, HydroEnergyVariableDown, devices, HydroDispatchPumpedStorage()) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| PSI.add_variables!(container, HydroEnergyVariableUp, devices, HydroDispatchPumpedStorage()) | |
| PSI.add_variables!(container, HydroEnergyVariableDown, devices, HydroDispatchPumpedStorage()) | |
| PSI.add_variables!( | |
| container, | |
| HydroEnergyVariableUp, | |
| devices, | |
| HydroDispatchPumpedStorage(), | |
| ) | |
| PSI.add_variables!( | |
| container, | |
| HydroEnergyVariableDown, | |
| devices, | |
| HydroDispatchPumpedStorage(), | |
| ) |
src/hydro_generation.jl
Outdated
| @@ -571,9 +580,9 @@ function PSI.add_constraints!( | |||
| resolution = PSI.get_resolution(container) | |||
| fraction_of_hour = Dates.value(Dates.Minute(resolution)) / PSI.MINUTES_IN_HOUR | |||
| names = [PSY.get_name(x) for x in devices] | |||
| initial_conditions = PSI.get_initial_condition(container, InitialEnergyLevelDown(), V) | |||
| initial_conditions = PSI.get_initial_condition(container, InitialHydroEnergyLevelDown(), V) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| initial_conditions = PSI.get_initial_condition(container, InitialHydroEnergyLevelDown(), V) | |
| initial_conditions = | |
| PSI.get_initial_condition(container, InitialHydroEnergyLevelDown(), V) |
src/hydro_generation.jl
Outdated
Comment on lines
875
to
876
| var_val = | ||
| PSI.get_variable_value(store, EnergyVariableUp(), PSI.get_component_type(ic)) | ||
| PSI.get_variable_value(store, HydroEnergyVariableUp(), PSI.get_component_type(ic)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| var_val = | |
| PSI.get_variable_value(store, EnergyVariableUp(), PSI.get_component_type(ic)) | |
| PSI.get_variable_value(store, HydroEnergyVariableUp(), PSI.get_component_type(ic)) | |
| var_val = PSI.get_variable_value( | |
| store, | |
| HydroEnergyVariableUp(), | |
| PSI.get_component_type(ic), | |
| ) |
src/hydro_generation.jl
Outdated
Comment on lines
876
to
877
| var_val = | ||
| PSI.get_variable_value(store, EnergyVariableUp(), PSI.get_component_type(ic)) | ||
| PSI.get_variable_value(store, HydroEnergyVariableUp(), PSI.get_component_type(ic)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| var_val = | |
| PSI.get_variable_value(store, EnergyVariableUp(), PSI.get_component_type(ic)) | |
| PSI.get_variable_value(store, HydroEnergyVariableUp(), PSI.get_component_type(ic)) | |
| var_val = PSI.get_variable_value( | |
| store, | |
| HydroEnergyVariableUp(), | |
| PSI.get_component_type(ic), | |
| ) |
src/hydro_generation.jl
Outdated
Comment on lines
876
to
877
| var_val = | ||
| PSI.get_variable_value(store, EnergyVariableUp(), PSI.get_component_type(ic)) | ||
| PSI.get_variable_value(store, HydroEnergyVariableUp(), PSI.get_component_type(ic)) |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| var_val = | |
| PSI.get_variable_value(store, EnergyVariableUp(), PSI.get_component_type(ic)) | |
| PSI.get_variable_value(store, HydroEnergyVariableUp(), PSI.get_component_type(ic)) | |
| var_val = PSI.get_variable_value( | |
| store, | |
| HydroEnergyVariableUp(), | |
| PSI.get_component_type(ic), | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to avoid issues with the NTP models. Some of these cases were not covered by the tests.