Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable Cost Refactor Part 2: PowerSimulations #332

Merged
merged 3 commits into from
Feb 26, 2024

Conversation

GabrielKS
Copy link
Contributor

The second part of a significant refactor of Sienna cost data structures (part 1 is here). The main focus here is to bring PowerSimulations.jl up to date with the elimination of VariableCost in favor of FunctionData. That entails these changes in InfrastructureSystems:

  • Make PiecewiseLinearPointData use NamedTuples so it's even harder to mix up x and y
  • Add the notion of "raw data" to support storing data from FunctionData in other containers, like the ones in PowerSimulations

On the latter point — does this functionality belong in PowerSimulations?

Tests pass:
Screenshot 2024-02-26 at 4 32 27 AM

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.09%. Comparing base (7f0d636) to head (8155747).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   79.99%   80.09%   +0.10%     
==========================================
  Files          54       54              
  Lines        4319     4336      +17     
==========================================
+ Hits         3455     3473      +18     
+ Misses        864      863       -1     
Flag Coverage Δ
unittests 80.09% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/common.jl 100.00% <ø> (ø)
src/function_data.jl 98.91% <100.00%> (+0.32%) ⬆️

... and 3 files with indirect coverage changes

src/function_data.jl Outdated Show resolved Hide resolved
src/function_data.jl Outdated Show resolved Hide resolved
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Alias instead of declaring the NamedTuple everywhere.

@jd-lara jd-lara merged commit f5ad28e into main Feb 26, 2024
8 of 10 checks passed
@jd-lara jd-lara deleted the gks/variable_cost_refactor_2 branch February 26, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants