Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use read_results_with_keys #21

Merged
merged 2 commits into from
Feb 17, 2024
Merged

use read_results_with_keys #21

merged 2 commits into from
Feb 17, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Feb 17, 2024

Very old pending code.

@jd-lara jd-lara self-assigned this Feb 17, 2024
@jd-lara jd-lara added the bug Something isn't working label Feb 17, 2024
@jd-lara jd-lara linked an issue Feb 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (743b0af) 88.46% compared to head (9bda646) 88.46%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files           3        3           
  Lines         312      312           
=======================================
  Hits          276      276           
  Misses         36       36           
Flag Coverage Δ
unittests 88.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, tests are back to passing on my end

@jd-lara jd-lara merged commit eca7764 into main Feb 17, 2024
7 checks passed
@jd-lara jd-lara deleted the jd/fix_read_results_with_keys branch July 10, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSI old code removal broke PG
2 participants