Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rh/add vector to methods #1106

Merged
merged 6 commits into from
May 13, 2024
Merged

Rh/add vector to methods #1106

merged 6 commits into from
May 13, 2024

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented May 9, 2024

This PR hopefully won't conflict with PSY 4

src/simulation/simulation.jl Outdated Show resolved Hide resolved
src/simulation/simulation.jl Outdated Show resolved Hide resolved
jd-lara and others added 2 commits May 9, 2024 12:46
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented May 9, 2024

Performance Results

Version Precompile Time
Main 3.220957385
This Branch 3.23753598
Version Build Time
Main-Build Time Precompile 48.924485599
Main-Build Time Postcompile 2.248550119
This Branch-Build Time Precompile 49.696762972
This Branch-Build Time Postcompile 2.385091348
Version Build Time
Main-Solve Time Precompile 949.581303606
Main-Solve Time Postcompile 929.654521793
This Branch-Solve Time Precompile 576.588142793
This Branch-Solve Time Postcompile 555.064793881

@jd-lara jd-lara requested a review from GabrielKS May 13, 2024 17:59
Copy link
Contributor

@GabrielKS GabrielKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with the context here so I can't vouch for the correctness of the code, but I am fairly confident it does not conflict with PSY4.

@jd-lara
Copy link
Member Author

jd-lara commented May 13, 2024

Not familiar with the context here so I can't vouch for the correctness of the code, but I am fairly confident it does not conflict with PSY4.

This is a bunch of bug fixes to handle HybridSystemsSimulations.jl

@jd-lara jd-lara merged commit 0673736 into main May 13, 2024
5 of 7 checks passed
@jd-lara jd-lara deleted the rh/add_vector_to_methods branch May 15, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants