Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model constructor and basic service representation #55

Merged
merged 11 commits into from
Oct 7, 2018

Conversation

claytonpbarrows
Copy link
Member

No description provided.

Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will approve the PR, the comments are just suggestions or things to be careful about.

src/base/model_constructors.jl Show resolved Hide resolved
src/core/abstract_models.jl Show resolved Hide resolved
end


#TODO: Make additional methods to handle other device types
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might need to be carefully implemented because in many cases can get generators or load that have fix time series.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but I will leave it as a TODO

@claytonpbarrows claytonpbarrows merged commit 6be6fa8 into master Oct 7, 2018
@claytonpbarrows claytonpbarrows deleted the model-constructor branch October 7, 2018 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants