Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs issues #349

Merged
merged 2 commits into from
Aug 4, 2023
Merged

fix docs issues #349

merged 2 commits into from
Aug 4, 2023

Conversation

rodrigomha
Copy link
Contributor

Closes #344 and #342

@rodrigomha rodrigomha added the documentation Improvements or additions to documentation label Aug 4, 2023
@rodrigomha rodrigomha requested a review from jd-lara August 4, 2023 06:00
@rodrigomha rodrigomha self-assigned this Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #349 (6f6deaf) into main (f50405c) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   87.49%   87.48%   -0.02%     
==========================================
  Files          65       65              
  Lines        8619     8619              
==========================================
- Hits         7541     7540       -1     
- Misses       1078     1079       +1     
Flag Coverage Δ
unittests 87.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Performance Results

Version Precompile Time
Main 4.729937233
This Branch 5.175678546
Version Run Time
Main-Build ResidualModel 12.065893326
Main-Execute ResidualModel 32.808683185
Main-Build MassMatrixModel 1.038082306
Main-Execute MassMatrixModel 430.180844783
This Branch-Build ResidualModel 11.792215608
This Branch-Execute ResidualModel 31.609173024
This Branch-Build MassMatrixModel 1.016031026
This Branch-Execute MassMatrixModel 435.394813465

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

@jd-lara jd-lara merged commit 652b313 into main Aug 4, 2023
9 checks passed
@jd-lara jd-lara deleted the rh/fix_powerflow_doc branch August 4, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix powerflow usage in tutorials
2 participants