Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to PSY3, PF 0.6 and PNM 0.9 #359

Merged
merged 12 commits into from
Dec 12, 2023
Merged

Bump to PSY3, PF 0.6 and PNM 0.9 #359

merged 12 commits into from
Dec 12, 2023

Conversation

rodrigomha
Copy link
Contributor

No description provided.

Copy link
Contributor

github-actions bot commented Dec 4, 2023

Performance Results

Version Precompile Time
Main 3.546540187
This Branch 3.032139354
Version Execute Time
Main-Build ResidualModel 6.735275877
Main-Execute ResidualModel 18.976536413
Main-Build MassMatrixModel 0.661233964
Main-Execute MassMatrixModel 27.119705775
This Branch-Build ResidualModel 7.121003229
This Branch-Execute ResidualModel 19.063483287
This Branch-Build MassMatrixModel 0.675907667
This Branch-Execute MassMatrixModel 28.079891926

ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests

@rodrigomha rodrigomha marked this pull request as ready for review December 7, 2023 19:15
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #359 (2644265) into main (4a7cca9) will increase coverage by 0.40%.
The diff coverage is 100.00%.

❗ Current head 2644265 differs from pull request most recent head 43c3088. Consider uploading reports for the commit 43c3088 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
+ Coverage   87.01%   87.42%   +0.40%     
==========================================
  Files          65       65              
  Lines        9048     9001      -47     
==========================================
- Hits         7873     7869       -4     
+ Misses       1175     1132      -43     
Flag Coverage Δ
unittests 87.42% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/base/frequency_reference.jl 88.23% <ø> (ø)
src/base/simulation_initialization.jl 83.13% <100.00%> (ø)
.../initialization/inverter_components/init_DCside.jl 100.00% <ø> (ø)
...itialization/inverter_components/init_converter.jl 96.07% <ø> (ø)
.../initialization/inverter_components/init_filter.jl 98.88% <ø> (ø)
...on/inverter_components/init_frequency_estimator.jl 97.10% <ø> (ø)
...c/initialization/inverter_components/init_inner.jl 97.35% <ø> (ø)
...c/initialization/inverter_components/init_outer.jl 98.47% <ø> (ø)
src/models/device.jl 94.69% <ø> (-0.32%) ⬇️
src/models/inverter_models/DCside_models.jl 100.00% <ø> (ø)
... and 6 more

... and 4 files with indirect coverage changes

@@ -148,3 +148,8 @@ function transform_load_to_constant_power(load::PSY.StandardLoad)
PSY.set_max_impedance_reactive_power!(load, 0.0)
return
end

# TO REMOVE AFTER UPDATE IN PSY
function PSY.get_reactive_power_limits(x::PSY.Source)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jd-lara we need to move this to PSY eventually

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you open a PR with this too and make a single group of releases please?

@rodrigomha
Copy link
Contributor Author

Tests are passing locally with main of PSY, but they do not pass with 3.1.1

@jd-lara jd-lara merged commit 94db9e1 into main Dec 12, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants