-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to PSY3, PF 0.6 and PNM 0.9 #359
Conversation
Performance Results
ResidualModel and MassMatrixModel performance results should be compared between versions and not between models due to the execution order of the tests |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #359 +/- ##
==========================================
+ Coverage 87.01% 87.42% +0.40%
==========================================
Files 65 65
Lines 9048 9001 -47
==========================================
- Hits 7873 7869 -4
+ Misses 1175 1132 -43
Flags with carried forward coverage won't be shown. Click here to find out more.
|
src/utils/psy_utils.jl
Outdated
@@ -148,3 +148,8 @@ function transform_load_to_constant_power(load::PSY.StandardLoad) | |||
PSY.set_max_impedance_reactive_power!(load, 0.0) | |||
return | |||
end | |||
|
|||
# TO REMOVE AFTER UPDATE IN PSY | |||
function PSY.get_reactive_power_limits(x::PSY.Source) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jd-lara we need to move this to PSY eventually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you open a PR with this too and make a single group of releases please?
Tests are passing locally with main of PSY, but they do not pass with 3.1.1 |
No description provided.