Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Eliminate repeated allocation of return nodes
- Loading branch information
1 parent
f0a4a37
commit 0ac3fd3
Showing
1 changed file
with
12 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ac3fd3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Myoldmopar this breaks unit tests because these aren't deallocated in a
clear_state
call.0ac3fd3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Myoldmopar The
AllocateFlag
needs to be bumped up to the module level and added toclear_state
. Or would it be better to just move fixedReturn intoZoneEquipConfig
? If you want to revert this, I can do that over in #70590ac3fd3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way is OK with me. Moving it up to the module level might be one step easier, but if you are inclined to add that to the zone equipment struct that's really great. I was about to just hot fix this but I'll step away and let you to add in #7059. Thanks @mjwitte ! And thanks for diagnosing this detective @nmerket !
0ac3fd3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, maybe you should hotfix it for now, 'cause the other may be a few days before it gets in. Sorry to flipflop.