Skip to content

Commit

Permalink
Add warnings to account for DOAS coil sizing
Browse files Browse the repository at this point in the history
  • Loading branch information
rraustad committed Sep 12, 2018
1 parent be61d9e commit 26b6d5b
Showing 1 changed file with 25 additions and 1 deletion.
26 changes: 25 additions & 1 deletion src/EnergyPlus/SingleDuct.cc
Expand Up @@ -6023,9 +6023,33 @@ namespace SingleDuct {
if (inletATMixerIndex == 0) return; // protect this function from bad inputs
if (controlledZoneNum == 0) return;
if (curZoneEqNum == 0) return;
if (SingleDuct::SysATMixer(inletATMixerIndex).MixerType == DataHVACGlobals::No_ATMixer) return;

// ATMixer properties only affect coil sizing when the mixer is on the inlet side of zone equipment
if (SingleDuct::SysATMixer(inletATMixerIndex).MixerType != DataHVACGlobals::ATMixer_InletSide) return;
if (SingleDuct::SysATMixer(inletATMixerIndex).MixerType == DataHVACGlobals::ATMixer_SupplySide) {
// check if user has selected No to account for DOAS system
if (FinalZoneSizing.allocated()) {
if (!FinalZoneSizing(curZoneEqNum).AccountForDOAS && FinalZoneSizing(curZoneEqNum).DOASControlStrategy != DOANeutralSup) {
ShowWarningError("AirTerminal:SingleDuct:Mixer: " + SingleDuct::SysATMixer(inletATMixerIndex).Name);
ShowContinueError(" Sizing:Zone object sets input Account for Dedicated Outdoor Air System = No.");
ShowContinueError(
" This supply side Air Terminal Mixer will not adjust coil sizing and may result in inappropriately sized coils.");
ShowContinueError(" Set Account for Dedicated Outdoor Air System = Yes in Sizing:Zone object for zone = " +
FinalZoneSizing(curZoneEqNum).ZoneName);
}
}
return; // do nothing else if this is a supply side ATMixer
}
// check if user has selected Yes to account for DOAS system
if (FinalZoneSizing.allocated()) {
if (FinalZoneSizing(curZoneEqNum).AccountForDOAS && FinalZoneSizing(curZoneEqNum).DOASControlStrategy != DOANeutralSup) {
ShowWarningError("AirTerminal:SingleDuct:Mixer: " + SingleDuct::SysATMixer(inletATMixerIndex).Name);
ShowContinueError(" Sizing:Zone object sets input Account for Dedicated Outdoor Air System = Yes.");
ShowContinueError(" This inlet side Air Terminal Mixer will also adjust coil sizing and may result in inappropriately sized coils.");
ShowContinueError(" Set Account for Dedicated Outdoor Air System = No in Sizing:Zone object for zone = " +
FinalZoneSizing(curZoneEqNum).ZoneName);
}
}

// proceed to set ATMixer properties used for sizing coils

Expand Down

8 comments on commit 26b6d5b

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - i386-Windows-7-VisualStudio-14: OK (3002 of 3002 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - Win64-Windows-7-VisualStudio-14: OK (2969 of 3002 tests passed, 22 test warnings)

Messages:

  • 32 tests had: Table big diffs.
  • 11 tests had: BND diffs.
  • 4 tests had: MTD diffs.
  • 12 tests had: RDD diffs.
  • 8 tests had: Table small diffs.
  • 8 tests had: ERR diffs.
  • 31 tests had: EIO diffs.
  • 13 tests had: ESO big diffs.
  • 8 tests had: MTR big diffs.
  • 6 tests had: ESO small diffs.
  • 4 tests had: MTR small diffs.

Failures:

regression Test Summary

  • Passed: 598
  • Failed: 33

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-MacOS-10.9-clang: OK (2969 of 3002 tests passed, 22 test warnings)

Messages:

  • 32 tests had: Table big diffs.
  • 11 tests had: BND diffs.
  • 4 tests had: MTD diffs.
  • 12 tests had: RDD diffs.
  • 7 tests had: Table small diffs.
  • 8 tests had: ERR diffs.
  • 30 tests had: EIO diffs.
  • 13 tests had: ESO big diffs.
  • 8 tests had: MTR big diffs.
  • 6 tests had: ESO small diffs.
  • 4 tests had: MTR small diffs.

Failures:

regression Test Summary

  • Passed: 598
  • Failed: 33

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (3009 of 3042 tests passed, 23 test warnings)

Messages:

  • 32 tests had: Table big diffs.
  • 11 tests had: BND diffs.
  • 4 tests had: MTD diffs.
  • 12 tests had: RDD diffs.
  • 8 tests had: Table small diffs.
  • 31 tests had: EIO diffs.
  • 9 tests had: ERR diffs.
  • 13 tests had: ESO big diffs.
  • 8 tests had: MTR big diffs.
  • 7 tests had: ESO small diffs.
  • 4 tests had: MTR small diffs.

Failures:

regression Test Summary

  • Passed: 618
  • Failed: 33

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1738 of 1738 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2374 of 2374 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

Please sign in to comment.