Skip to content

Commit

Permalink
Revert new warning for negative thermal production
Browse files Browse the repository at this point in the history
Forgot that there are times when microcogen and PVT will producing
cooling (heat capacity in cold engine and night sky cooling)
  • Loading branch information
EnergyArchmage committed Mar 6, 2016
1 parent 7b974fe commit 3018dce
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/EnergyPlus/ElectricPowerServiceManager.cc
Expand Up @@ -2082,16 +2082,6 @@ namespace EnergyPlus {
electricPowerOutput = 0.0;
}

if ( thermalPowerOutput < 0.0 ) {
if ( errCountNegThermProd_ == 0 ) {
ShowWarningMessage( typeOfName + " named " + name + " is producing negative thermal power, check generator inputs." );
ShowContinueError( "Thermal power production rate =" + General::RoundSigDigits( thermalPowerOutput, 4 ) );
ShowContinueError( "The power will be set to zero, and the simulation continues... " );
}
ShowRecurringWarningErrorAtEnd( typeOfName + " named " + name + " is producing negative thermal power ", errCountNegThermProd_,thermalPowerOutput, thermalPowerOutput );
thermalPowerOutput = 0.0;
}

}

DCtoACInverter::DCtoACInverter(
Expand Down

8 comments on commit 3018dce

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1022 of 1022 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-MacOS-10.9-clang: OK (2124 of 2130 tests passed, 3 test warnings)

  • 9 tests had: AUD diffs.
  • 9 tests had: MDD diffs.
  • 9 tests had: MTD diffs.
  • 1 test had: ERR diffs.
  • 6 tests had: ESO big diffs.
  • 1 test had: MTR big diffs.
  • 1 test had: RDD diffs.
  • 1 test had: Table big diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2162 of 2168 tests passed, 3 test warnings)

  • 9 tests had: AUD diffs.
  • 9 tests had: MDD diffs.
  • 9 tests had: MTD diffs.
  • 1 test had: ERR diffs.
  • 6 tests had: ESO big diffs.
  • 1 test had: MTR big diffs.
  • 1 test had: RDD diffs.
  • 1 test had: Table big diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (1580 of 1580 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - Win64-Windows-7-VisualStudio-12: OK (2130 of 2136 tests passed, 3 test warnings)

  • 9 tests had: AUD diffs.
  • 9 tests had: MDD diffs.
  • 9 tests had: MTD diffs.
  • 1 test had: ERR diffs.
  • 6 tests had: ESO big diffs.
  • 1 test had: MTR big diffs.
  • 1 test had: RDD diffs.
  • 1 test had: Table big diffs.

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5528-Generators-Trap-Neg-SandiaPV-Zenith (EnergyArchmage) - i386-Windows-7-VisualStudio-12: OK (2130 of 2136 tests passed, 3 test warnings)

  • 9 tests had: AUD diffs.
  • 9 tests had: MDD diffs.
  • 9 tests had: MTD diffs.
  • 1 test had: ERR diffs.
  • 6 tests had: ESO big diffs.
  • 1 test had: MTR big diffs.
  • 1 test had: RDD diffs.
  • 1 test had: Table big diffs.

Build Badge Test Badge

Please sign in to comment.