-
Notifications
You must be signed in to change notification settings - Fork 376
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Correction of negative cooling reporting
Bug that was resulting in cooling being negative in output. The cooling is not negative—it was simply picking up the fact that the cooling panel has a heat removal impact on zones. However, all the output variables are clearly cooling so these should not show up as negative. This commit fixes that and adds a unit test.
- Loading branch information
Showing
2 changed files
with
33 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b205de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
150945455-Cooling-Panel-Mods (RKStrand) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)
6b205de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
150945455-Cooling-Panel-Mods (RKStrand) - i386-Windows-7-VisualStudio-14: OK (2792 of 2792 tests passed, 0 test warnings)
6b205de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
150945455-Cooling-Panel-Mods (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1566 of 1566 tests passed, 0 test warnings)
6b205de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
150945455-Cooling-Panel-Mods (RKStrand) - x86_64-MacOS-10.9-clang: OK (2788 of 2792 tests passed, 0 test warnings)
Messages:
Failures:
regression Test Summary
6b205de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
150945455-Cooling-Panel-Mods (RKStrand) - Win64-Windows-7-VisualStudio-14: OK (2788 of 2792 tests passed, 0 test warnings)
Messages:
Failures:
regression Test Summary
6b205de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
150945455-Cooling-Panel-Mods (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2183 of 2183 tests passed, 0 test warnings)
6b205de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
150945455-Cooling-Panel-Mods (RKStrand) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)
6b205de
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
150945455-Cooling-Panel-Mods (RKStrand) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2828 of 2832 tests passed, 0 test warnings)