Skip to content

Commit

Permalink
Coil sizing report - minor title change and add output rules
Browse files Browse the repository at this point in the history
  • Loading branch information
@mjwitte
mjwitte committed Feb 20, 2018
1 parent b20c099 commit 6bb8d01
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/EnergyPlus/OutputReportPredefined.cc
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1956,7 +1956,7 @@ namespace OutputReportPredefined {
pdchPlantSizPkTimeHour = newPreDefColumn( pdstPlantSize, "Peak Hour Of Day {TIMESTAMP}[hr]" );
pdchPlantSizPkTimeMin = newPreDefColumn( pdstPlantSize, "Peak Step Start Minute {TIMESTAMP}[min]" );

pdst2CoilSummaryCoilSelection = newPreDefSubTable( pdrSizing, "Coil Sizing Summary Report" );
pdst2CoilSummaryCoilSelection = newPreDefSubTable( pdrSizing, "Coil Sizing Summary" );
// coil meta data information
// the first column will be the coil name, the unique user name from input. It has no header or column definition
pdch2CoilType = newPreDefColumn( pdst2CoilSummaryCoilSelection, "Coil Type" );
Expand Down
9 changes: 8 additions & 1 deletion src/Transition/OutputRulesFiles/OutputChanges8-8-0-to-8-9-0.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ External Shading Calculation Method, Output External Shading Calculation Results

See [6390](https://github.com/NREL/EnergyPlus/pull/6390)

### System Sizing New Outputs
### New System Sizing Outputs

A part of a system sizing refactor which includes bug fixes for Std 62.1 sizing, there are several new component sizing outputs that appear in every file with an airloop:
```
Expand All @@ -30,3 +30,10 @@ Component Sizing Information, AirLoopHVAC, VAV SYS 1, Calculated Heating Air Flo

See [6372](https://github.com/NREL/EnergyPlus/pull/6372)

### New Coil Sizing Reports

A new subtable "Coil Sizing Summary" has been added at the end of the "HVAC Sizing Summary" (HVACSizingSummary) report. This new subtable is always produced with this report.

A new "Coils Sizing Details" (CoilSizingDetails) report has been added. It is an optional report which is included with AllSummary*. The new report has over 80 columns of data. The "Coil Sizing Summary" subtable described above is a straight subset of this report with only about 30 columns.

See [6454](https://github.com/NREL/EnergyPlus/pull/6454)

6 comments on commit 6bb8d01

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoilSizingReport (mjwitte) - x86_64-MacOS-10.9-clang: OK (2860 of 2863 tests passed, 619 test warnings)

Messages:

  • 622 tests had: AUD diffs.
  • 101 tests had: ERR diffs.
  • 3 tests had: EIO diffs.
  • 2 tests had: ESO small diffs.
  • 3 tests had: Table big diffs.
  • 1 test had: Table small diffs.
  • 1 test had: ESO big diffs.
  • 1 test had: MTR big diffs.

Failures:

regression Test Summary

  • Passed: 619
  • Failed: 3

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoilSizingReport (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2900 of 2903 tests passed, 623 test warnings)

Messages:

  • 626 tests had: AUD diffs.
  • 100 tests had: ERR diffs.
  • 3 tests had: EIO diffs.
  • 2 tests had: ESO small diffs.
  • 3 tests had: Table big diffs.
  • 1 test had: Table small diffs.
  • 1 test had: ESO big diffs.
  • 1 test had: MTR big diffs.

Failures:

regression Test Summary

  • Passed: 639
  • Failed: 3

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoilSizingReport (mjwitte) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoilSizingReport (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1617 of 1617 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoilSizingReport (mjwitte) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2244 of 2244 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CoilSizingReport (mjwitte) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

Please sign in to comment.