Skip to content

Commit

Permalink
Update humrat calculation for water coil sizing in HeatingWaterDesCoi…
Browse files Browse the repository at this point in the history 
…lLoadUsedForUASizing
  • Loading branch information
@rraustad
rraustad committed Aug 24, 2017
1 parent a00ab1a commit a6e1d7e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/EnergyPlus/ReportSizingManager.cc
View file
Expand Up @@ -1136,6 +1136,9 @@ namespace ReportSizingManager {
CoilInTemp = FinalZoneSizing( CurZoneEqNum ).DesHeatCoilInTempTU;
} else {
CoilInTemp = FinalZoneSizing( CurZoneEqNum ).DesHeatCoilInTemp;
// DELETE THIS MESSAGE: only testing to see if any example files use this line of code
// can probably combine the ZoneEqFanCoil code above and this to consolidate?
ShowWarningMessage( CallingRoutine + ": Sizing for " + CompType + ' ' + CompName + " using DesHeatCoilInTemp without checking for OA fraction. " );
}
if ( ( TermUnitSingDuct || TermUnitPIU ) && ( CurTermUnitSizingNum > 0 ) ) {
CoilOutTemp = FinalZoneSizing( CurZoneEqNum ).HeatDesTemp;
Expand Down Expand Up @@ -1258,7 +1261,7 @@ namespace ReportSizingManager {
OutAirFrac = 0.0;
}
CoilInTemp = ( 1.0 - OutAirFrac ) * FinalZoneSizing( CurZoneEqNum ).ZoneTempAtHeatPeak + OutAirFrac * FinalZoneSizing( CurZoneEqNum ).OutTempAtHeatPeak;
CoilInHumRat = FinalZoneSizing( CurZoneEqNum ).DesHeatCoilInHumRat;
CoilInHumRat = ( 1.0 - OutAirFrac ) * FinalZoneSizing( CurZoneEqNum ).ZoneHumRatAtHeatPeak + OutAirFrac * FinalZoneSizing( CurZoneEqNum ).OutHumRatAtHeatPeak;
CoilOutTemp = FinalZoneSizing( CurZoneEqNum ).HeatDesTemp;
CoilOutHumRat = FinalZoneSizing( CurZoneEqNum ).HeatDesHumRat;
AutosizeDes = PsyCpAirFnWTdb( CoilOutHumRat, 0.5 * ( CoilInTemp + CoilOutTemp ) ) * DesMassFlow * ( CoilOutTemp - CoilInTemp );
Expand Down

8 comments on commit a6e1d7e

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero (rraustad) - i386-Windows-7-VisualStudio-14: OK (2749 of 2749 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero (rraustad) - Win64-Windows-7-VisualStudio-14: OK (2749 of 2749 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero (rraustad) - x86_64-MacOS-10.9-clang: OK (2732 of 2743 tests passed, 43 test warnings)

Messages:

  • 53 tests had: ERR diffs.
  • 12 tests had: EIO diffs.
  • 6 tests had: ESO big diffs.
  • 11 tests had: Table big diffs.
  • 1 test had: ESO small diffs.
  • 5 tests had: MTR big diffs.
  • 1 test had: AUD diffs.
  • 1 test had: MTD diffs.
  • 1 test had: RDD diffs.
  • 1 test had: Table small diffs.
  • 1 test had: MTR small diffs.

Failures:

regression Test Summary

  • Passed: 595
  • Failed: 11

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2728 of 2783 tests passed, 0 test warnings)

  • 54 tests had: ERR diffs.
  • 12 tests had: EIO diffs.
  • 6 tests had: ESO big diffs.
  • 11 tests had: Table big diffs.
  • 1 test had: AUD diffs.
  • 1 test had: MTD diffs.
  • 1 test had: RDD diffs.
  • 1 test had: Table small diffs.
  • 1 test had: ESO small diffs.
  • 5 tests had: MTR big diffs.
  • 1 test had: MTR small diffs.

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1529 of 1529 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero (rraustad) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6028-PTAC-heating-coil-undersized-for-ventilation-load-when-zone-design-heating-load-is-zero (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2139 of 2140 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.