Skip to content

Commit

Permalink
Correct energyplus_tests so CI will compile
Browse files Browse the repository at this point in the history
  • Loading branch information
@rraustad
rraustad committed Jun 20, 2018
1 parent 4192eb6 commit ac5ebb8
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions tst/EnergyPlus/unit/FanCoilUnits.unit.cc
View file
Expand Up @@ -2102,7 +2102,7 @@ TEST_F(EnergyPlusFixture, FanCoil_ASHRAE90VariableFan)
StdRhoAir = 1.2;

BeginEnvrnFlag = true;
InitFanCoilUnits(FanCoilNum, ZoneNum);
InitFanCoilUnits(FanCoilNum, ZoneNum, ZoneNum);
Sim4PipeFanCoil(FanCoilNum, ZoneNum, ZoneNum, FirstHVACIteration, QUnitOut, QLatOut);

// expect full flow and meet capacity
Expand Down Expand Up @@ -2759,7 +2759,7 @@ TEST_F(EnergyPlusFixture, FanCoil_CyclingFanMode)
StdRhoAir = 1.2;

BeginEnvrnFlag = true;
InitFanCoilUnits(FanCoilNum, ZoneNum);
InitFanCoilUnits(FanCoilNum, ZoneNum, ZoneNum);
Sim4PipeFanCoil(FanCoilNum, ZoneNum, ZoneNum, FirstHVACIteration, QUnitOut, QLatOut);
// expect fan speed 3 and near full air and water flow and meet capacity
EXPECT_EQ(3, FanCoil(1).SpeedFanSel);
Expand Down
2 changes: 1 addition & 1 deletion tst/EnergyPlus/unit/HeatRecovery.unit.cc
View file
Expand Up @@ -3809,7 +3809,7 @@ TEST_F(EnergyPlusFixture, HeatRecoveryHXOnMainBranch_SimHeatRecoveryTest)

ASSERT_NEAR(-17.300, ExchCond(1).SupInTemp, 0.001); // Heat Recovery Exchanger Primary Air Inlet Temp
ASSERT_GT(ExchCond(1).SupOutTemp, ExchCond(1).SupInTemp); // Heat Recovery Exchanger is On in heating mode
ASSERT_NEAR(23.000, ExchCond(1).SecInTemp, 0.001); // Heat Recovery Exchanger Secondary Air Inlet Temp
ASSERT_NEAR(22.436, ExchCond(1).SecInTemp, 0.001); // Heat Recovery Exchanger Secondary Air Inlet Temp
ASSERT_LT(ExchCond(1).SecOutTemp, ExchCond(1).SecInTemp); // Heat Recovery Exchanger is On in heating mode

InletNode = ExchCond(1).SupInletNode;
Expand Down
2 changes: 1 addition & 1 deletion tst/EnergyPlus/unit/UnitHeater.unit.cc
View file
Expand Up @@ -1148,7 +1148,7 @@ TEST_F(EnergyPlusFixture, UnitHeater_HWHeatingCoilUAAutoSizingTest)
// calculate hot water coil design capacity
HWCoilDesignCapacity = HWMaxVolFlowRate * HWDensity * CpHW * HWPlantDeltaTDesign;
EXPECT_NEAR(HWCoilDesignCapacity, WaterCoils::WaterCoil(CoilNum).DesWaterHeatingCoilRate, 1.0);
EXPECT_NEAR(188.51, WaterCoils::WaterCoil(CoilNum).UACoil, 0.02);
EXPECT_NEAR(161.22, WaterCoils::WaterCoil(CoilNum).UACoil, 0.02);
}

TEST_F(EnergyPlusFixture, UnitHeater_SimUnitHeaterTest)
Expand Down
8 changes: 4 additions & 4 deletions tst/EnergyPlus/unit/WaterCoils.unit.cc
View file
Expand Up @@ -376,10 +376,10 @@ TEST_F(WaterCoilsTest, WaterCoolingCoilSizing)
WaterCoil(CoilNum).MaxWaterVolFlowRate = AutoSize;

SizeWaterCoil(CoilNum);
EXPECT_NEAR(WaterCoil(CoilNum).InletAirTemp, 16.0, 0.0001); // a mixture of zone air (20 C) and 10% OA (-20 C) = 16 C
EXPECT_NEAR(WaterCoil(CoilNum).DesTotWaterCoilLoad, 1709.8638, 0.0001);
EXPECT_NEAR(WaterCoil(CoilNum).UACoil, 51.3278, 0.0001);
EXPECT_NEAR(WaterCoil(CoilNum).OutletAirTemp, 30.1302, 0.0001); // reasonable delta T above inlet air temp
EXPECT_NEAR(WaterCoil(CoilNum).InletAirTemp, -1.99999, 0.0001); // a mixture of zone air (20 C) and 10% OA (-20 C) = 16 C
EXPECT_NEAR(WaterCoil(CoilNum).DesTotWaterCoilLoad, 3908.2603, 0.0001);
EXPECT_NEAR(WaterCoil(CoilNum).UACoil, 94.9905, 0.0001);
EXPECT_NEAR(WaterCoil(CoilNum).OutletAirTemp, 30.2984, 0.0001); // reasonable delta T above inlet air temp
}

TEST_F(WaterCoilsTest, TdbFnHRhPbTest)
Expand Down

8 comments on commit ac5ebb8

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - i386-Windows-7-VisualStudio-14: OK (2929 of 2929 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-MacOS-10.9-clang: OK (2906 of 2929 tests passed, 8 test warnings)

Messages:

  • 8 tests had: AUD diffs.
  • 23 tests had: EIO diffs.
  • 17 tests had: ESO big diffs.
  • 16 tests had: MTR big diffs.
  • 21 tests had: Table big diffs.
  • 8 tests had: ERR diffs.
  • 6 tests had: ESO small diffs.

Failures:

regression Test Summary

  • Passed: 600
  • Failed: 23

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - Win64-Windows-7-VisualStudio-14: OK (2906 of 2929 tests passed, 11 test warnings)

Messages:

  • 11 tests had: AUD diffs.
  • 23 tests had: EIO diffs.
  • 17 tests had: ESO big diffs.
  • 16 tests had: MTR big diffs.
  • 21 tests had: Table big diffs.
  • 8 tests had: ERR diffs.
  • 6 tests had: ESO small diffs.

Failures:

regression Test Summary

  • Passed: 600
  • Failed: 23

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8: OK (2946 of 2969 tests passed, 11 test warnings)

Messages:

  • 11 tests had: AUD diffs.
  • 23 tests had: EIO diffs.
  • 17 tests had: ESO big diffs.
  • 16 tests had: MTR big diffs.
  • 21 tests had: Table big diffs.
  • 9 tests had: ERR diffs.
  • 6 tests had: ESO small diffs.

Failures:

regression Test Summary

  • Passed: 620
  • Failed: 23

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-UnitTestsCoverage-Debug: OK (1681 of 1681 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-gcc-4.8-IntegrationCoverage-Debug: OK (2309 of 2309 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6712-Zone-Coil-Autosizing-does-not-include-impact-of-AirTerminalSingleDuctMixer (rraustad) - x86_64-Linux-Ubuntu-14.04-custom_check: OK (0 of 0 tests passed, 0 test warnings)

Build Badge

Please sign in to comment.