Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behavior when using shading surfaces with transmittance schedule and PixelCounting #9059

Closed
marctavenier opened this issue Sep 14, 2021 · 7 comments · Fixed by #9653
Assignees
Labels
PriorityHigh This defect or feature has been declared high priority

Comments

@marctavenier
Copy link

Issue overview

When using shading surfaces with a transmittance schedule and the PixelCounting shading calculation method, the transmittance schedule seems to be ignored and all surfaces are made fully opaque. To me this seems to be a bug or at least unexpected behavior. When using PolygonClipping the transmittance schedule works as expected.

Details

Some additional details for this issue:

  • Windows 10
  • EnergyPlus 9.5 via OpenStudio 3.2.0 via Ladybug Tools 1.3.0 in Grasshopper.
  • As indicated on the Ladybug Tools Discourse here
@shorowit
Copy link
Contributor

shorowit commented May 2, 2022

As far as I can tell, EnergyPlus uses penumbra for the PixelCounting shading calculation, and according to @nealkruis, penumbra currently can't handle shading surfaces with any transparency.

At a minimum, it seems like there should be a warning (if there isn't already, I haven't checked).

@aaron-boranian
Copy link
Contributor

Related Unmet Hours post.

@rafael-a
Copy link

I just accidentally found this issue through the Unmet Hours post linked above.

As a user, this issue is critical as it biases the solar load without any alert/warning and can lead to the overestimation of heating loads unknowingly.
For context, we use transparency schedules quite often to model deciduous Trees over the year.

From my own point of view, it would be very appreciated to have a Severe warning show when this issue is encountered in a model.

@chriswmackey
Copy link

chriswmackey commented May 13, 2022

Oh wow. If this is true, I can't believe that I have been using this PixelCounting method for over a year and I have been completely unaware of this. This is probably one of the most dangerous cases of an error passing silently that I've encountered in recent E+ history.

I can support the lack of a FatalError since I imagine a lot of people would still like there simulation to continue for this case. However, there needs to at least be a SevereError in the .err file if we don't want more cases of people like me who have been using this method with transmittance schedules for several projects.

chriswmackey added a commit to chriswmackey/honeybee-energy that referenced this issue May 13, 2022
I just discovered [this issue](NREL/EnergyPlus#9059) and I have decided that it is better to use PolygonClipping with all of its limitations.
chriswmackey added a commit to ladybug-tools/honeybee-energy that referenced this issue May 13, 2022
I just discovered [this issue](NREL/EnergyPlus#9059) and I have decided that it is better to use PolygonClipping with all of its limitations.
@mjwitte mjwitte added the PriorityHigh This defect or feature has been declared high priority label Aug 31, 2022
@rafael-a
Copy link

rafael-a commented Dec 1, 2022

Hi @nealkruis, @shorowit,

I know this issue has now been closed as the Severe warning got implemented.

However, are there any plans to overcome PixelCounting limitation with translucent shading surfaces?

As a user, we use translucent shading surfaces when there are decidious trees that could have a significant impact on the building's solar gains. This means that a large portion of the buildings simulated with E+ can't make use of the speed up PixelCounting provides and still remain on the PolygonClipping era - in some cases we are talking about a x100 simulation time, which largely limits the amount of iterations we can make on a building design.

I imagine this is not an easy one to address, but it would have a large impact of a signficant number of cases.

@nealkruis
Copy link
Member

@rafael-a I have thought about how this could be done with PixelCounting, but unfortunately there are no immediate plans (or funding) to work on this.

@rafael-a
Copy link

rafael-a commented Jan 4, 2023

I understand, thanks @nealkruis!

Let me know if there is something we can do or any site to put a request?
I don't really know what is the process to develop/fund these modifications/new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PriorityHigh This defect or feature has been declared high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants