Prevent division by zero in WAHP heating design day calculations #10141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lymereJ
commented
Aug 7, 2023
Comment on lines
+1243
to
+1252
| Real64 PeakTotCapTempModFac = 1.0; // Peak total cooling capacity curve modifier | ||
| Real64 RatedTotCapTempModFac = 1.0; // Rated total cooling capacity curve modifier | ||
| Real64 PeakHeatCapTempModFac = 1.0; // Peak heating capacity curve modifier | ||
| Real64 DesignEntWaterTemp; // Design entering coil water temperature | ||
| Real64 SensCapAtPeak; // Sensible load on the cooling coil at cooling design conditions | ||
| Real64 PeakSensCapTempModFac = 0.0; // Peak sensible cooling capacity curve modifier | ||
| Real64 RatedSensCapTempModFac = 0.0; // Rated sensible cooling capacity curve modifier | ||
| Real64 RatedHeatCapTempModFac = 0.0; // Rated heating capacity curve modifier | ||
| Real64 RatedCoolPowerTempModFac = 0.0; // Rated cooling power curve modifier | ||
| Real64 RatedHeatPowerTempModFac = 0.0; // Rated heating power curve modifier | ||
| Real64 PeakSensCapTempModFac = 1.0; // Peak sensible cooling capacity curve modifier | ||
| Real64 RatedSensCapTempModFac = 1.0; // Rated sensible cooling capacity curve modifier | ||
| Real64 RatedHeatCapTempModFac = 1.0; // Rated heating capacity curve modifier | ||
| Real64 RatedCoolPowerTempModFac = 1.0; // Rated cooling power curve modifier | ||
| Real64 RatedHeatPowerTempModFac = 1.0; // Rated heating power curve modifier |
There was a problem hiding this comment.
Curve modifiers are initialized to 1.0 instead of 0 to avoid division by zero.
There was a problem hiding this comment.
This seems like a reasonable change.
lymereJ
commented
Aug 7, 2023
| @@ -1547,7 +1547,7 @@ TEST_F(EnergyPlusFixture, WaterToAirHeatPumpSimpleTest_SizeHVACWaterToAirRatedCo | |||
| state->dataWaterToAirHeatPumpSimple->SimpleWatertoAirHP(2).RatioRatedHeatRatedTotCoolCap = 1.23; | |||
|
|
|||
| state->dataSize->FinalZoneSizing(state->dataSize->CurZoneEqNum).DesCoolVolFlow = 0.20; | |||
| state->dataSize->FinalZoneSizing(state->dataSize->CurZoneEqNum).DesHeatVolFlow = 0.0; | |||
| state->dataSize->FinalZoneSizing(state->dataSize->CurZoneEqNum).DesHeatVolFlow = 0.0004; | |||
There was a problem hiding this comment.
Use an air flow that very small but greater than 0.
|
The diffs are expected and reflect the change in initial modifier value. |
Myoldmopar
approved these changes
Aug 16, 2023
Comment on lines
+1243
to
+1252
| Real64 PeakTotCapTempModFac = 1.0; // Peak total cooling capacity curve modifier | ||
| Real64 RatedTotCapTempModFac = 1.0; // Rated total cooling capacity curve modifier | ||
| Real64 PeakHeatCapTempModFac = 1.0; // Peak heating capacity curve modifier | ||
| Real64 DesignEntWaterTemp; // Design entering coil water temperature | ||
| Real64 SensCapAtPeak; // Sensible load on the cooling coil at cooling design conditions | ||
| Real64 PeakSensCapTempModFac = 0.0; // Peak sensible cooling capacity curve modifier | ||
| Real64 RatedSensCapTempModFac = 0.0; // Rated sensible cooling capacity curve modifier | ||
| Real64 RatedHeatCapTempModFac = 0.0; // Rated heating capacity curve modifier | ||
| Real64 RatedCoolPowerTempModFac = 0.0; // Rated cooling power curve modifier | ||
| Real64 RatedHeatPowerTempModFac = 0.0; // Rated heating power curve modifier | ||
| Real64 PeakSensCapTempModFac = 1.0; // Peak sensible cooling capacity curve modifier | ||
| Real64 RatedSensCapTempModFac = 1.0; // Rated sensible cooling capacity curve modifier | ||
| Real64 RatedHeatCapTempModFac = 1.0; // Rated heating capacity curve modifier | ||
| Real64 RatedCoolPowerTempModFac = 1.0; // Rated cooling power curve modifier | ||
| Real64 RatedHeatPowerTempModFac = 1.0; // Rated heating power curve modifier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
The fix is demonstrated through an update to an exiting test. Also, the defect file was run with this branch, the simulation complete successfully and the expected capacity is reported:
NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.