Mean Radiant Temperature from Zone to Enclosure #10244

mjwitte · 2023-09-26T20:33:03Z

Pull request overview

Fixes Mean Radiant Temperature (MRT) calculations are zone-based (not enclosure-based) #9377 (remaining pieces)
Builds on Calculate Mean Radiant Temperature (MRT) for Enclosures (not zones) #9628
Delete unused "Zone Name" field from ComfortViewFactorAngles
Change People "Mean Radiant Temperature Calculation Type" option from "ZoneAveraged" to "EnclosureAvereged"
Change "Watts per Zone Floor Area" fields to "Watts per Floor Area" in Lights, ElectricEquipment, and ElectricEquipment:ITE:AirCooled (not really related to MRT, but noticed it here).
Change "Power per Zone Floor Area" to "Power per Floor Area" in GasEquipment, HotWaterEquipment, and SteamEquipment.
Clean up CalcSurfaceWeightedMRT which was already using enclosures, but change from zone to space MAT as the fallback when the sum of surface areas*emissivities is zero.
Move loose ZoneMRT array to MRT field in zone/spaceHeatBalance struct.
Add new output variables for "Space Mean Radiant Temperature" and "Enclosure Mean Radiant Temperature".
Use enclosure MRT for interzone windows.
Use enclosure MRT for Space Operative Temperature (Zone Operative Temperature is still using Zone MRT).
Use enclosure MRT for thermal comfort (since People instances are all at the space level).

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

rraustad · 2023-09-30T17:22:58Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+                ShowContinueError(state, "As a result, MRT will be set to MAT for that zone");
+            }
+            state.dataHeatBal->ZoneMRT(ZoneNum) = state.dataZoneTempPredictorCorrector->zoneHeatBalance(ZoneNum).MAT;
+        }


I am staring at this if/else and wondering what the for loop at lines 5488 - 5495 represents when ZoneAESum(ZoneNum) <= 0.01. Same for the enclosure loop below at 5511. If ZoneAESum(ZoneNum) <= 0.01, then isn't sumAE also <= 0.01? And doesn't that mean that the for loop could be moved into this if block above line 5497? The only draw-back I see is the calculation of state.dataViewFactor->EnclRadInfo(state.dataSurface->Surface(SurfNum).RadEnclIndex).sumAET would only occur when ZoneAESum > 0.01.

@rraustad Good point - no sense in accumulating sumAET if it's not going to be used, because sumAE is zero.

Does this mean something still needs to be cleaned out here?

@Myoldmopar The comment was addressed. if (state.dataHeatBalSurfMgr->ZoneAESum(ZoneNum) > 0.01) { was moved up to line 5492, before the loop to accumulate zoneSumAET.

Excellent, thanks!

mjwitte

Code walkthru. This is ready for final review.

mjwitte · 2023-10-12T20:58:13Z

doc/input-output-reference/src/overview/group-thermal-zone-description-geometry.tex

+\paragraph{Space Mean Radiant Temperature {[}C{]}}\label{space-mean-radiant-temperature-c}
+\paragraph{Enclosure Mean Radiant Temperature {[}C{]}}\label{enclosure-mean-radiant-temperature-c}


Two new output variables. Note that Zone MRT is still calculated the legacy way, oblivious to enclosure boundaries.

mjwitte · 2023-10-12T21:00:17Z

idd/Energy+.idd.in

-       \key ZoneAveraged
+       \key EnclosureAveraged


key change for People. This now uses the enclosure MRT for the associated space. No longer using zone MRT.

Key change, people!

mjwitte · 2023-10-12T21:01:03Z

idd/Energy+.idd.in

-       \note Watts/Area => Watts per Zone Floor Area -- enter the number to apply. Value * Floor Area = Lights
+       \note Watts/Area => Watts per Floor Area -- enter the number to apply. Value * Floor Area = Lights


Some unrelated field name cleanup.

mjwitte · 2023-10-12T21:02:17Z

src/EnergyPlus/DataHeatBalance.hh

@@ -1913,7 +1916,6 @@ struct HeatBalanceData : BaseGlobalStruct
    Array1D<Real64> ZoneGroupSNLoadHeatRate;
    Array1D<Real64> ZoneGroupSNLoadCoolRate;

-    Array1D<Real64> ZoneMRT;        // MEAN RADIANT TEMPERATURE (C)


Moved this into zoneHeatBalance.MRT (and space.....)

mjwitte · 2023-10-12T21:03:01Z

src/EnergyPlus/DataViewFactorInformation.hh

+        Real64 sumAE = 0.0;     // Sum of surface area * emissivity for all surfaces in the enclosure
+        Real64 sumAET = 0.0;    // Sum of surface area * emissivity * temperature for all surfaces in the enclosure
+        Real64 MRT = 0.0;       // Mean radiant temperature of the enclosure
+        bool reCalcMRT = false; // True when MRT needs to be recalculated


New enclosure fields.

mjwitte · 2023-10-12T21:11:46Z

src/EnergyPlus/ThermalComfort.cc

-                thisAngFacList.SurfaceName(SurfNum) = state.dataIPShortCut->cAlphaArgs(SurfNum + 2);
+                thisAngFacList.SurfaceName(SurfNum) = state.dataIPShortCut->cAlphaArgs(SurfNum + 1);


Shift fields for ComfortViewFactorAngles

mjwitte · 2023-10-12T21:13:43Z

src/EnergyPlus/ThermalComfort.cc

+        case DataHeatBalance::CalcMRT::EnclosureAveraged: {
+            int enclNum = state.dataHeatBal->space(thisPeople.spaceIndex).radiantEnclosureNum;
+            state.dataThermalComforts->RadTemp = state.dataViewFactor->EnclRadInfo(enclNum).MRT;


Here's the change from zone to enclosure MRT for people.

"So why didn't this PR just change this one line?", he asks as he runs away laughing maniacally.

mjwitte · 2023-10-12T21:15:40Z

src/EnergyPlus/WindowComplexManager.cc

-                tsky = state.dataHeatBal->ZoneMRT(ZoneNumAdj) +
+                tsky = state.dataViewFactor->EnclRadInfo(enclNumAdj).MRT +


Use enclosure MRT for interzone windows.

mjwitte · 2023-10-12T21:16:53Z

src/Transition/CreateNewIDFUsingRules_template.f90

+      ! So instead, let's just move forward with a new 4 character string and use that in this file and the future
+      ! If we get to version 100.1 and we are still using this Fortran transition then well....we can deal with it then
+      sVersionNum = '***'
+      sVersionNumFourChars='23.2'


Updated the transition code template. @Myoldmopar this might break the version update script?

No it should be fine I think.

mjwitte · 2023-10-12T21:19:38Z

tst/EnergyPlus/unit/SurfaceGeometry.unit.cc

@@ -5841,6 +5846,77 @@ TEST_F(EnergyPlusFixture, HeatBalanceIntRadExchange_SetupEnclosuresWithAirBounda
    EXPECT_EQ(state->dataHeatBal->space(1).HTSurfaceLast, Zone1Floor);
    EXPECT_EQ(state->dataHeatBal->space(2).HTSurfaceLast, Zone2Floor);
    EXPECT_EQ(state->dataHeatBal->space(3).HTSurfaceLast, Zone3Floor);
+
+    // Check MRT calculations


Extend existing unit test to check MRT calcs. All other unit test changes are just to keep things working.

mjwitte · 2023-10-12T21:27:49Z

err diffs are new enclosure warning in a few files:

+   ** Warning ** Enclosure areas*inside surface emissivities are summing to zero, for Enclosure="ZONE ONE"
+   **   ~~~   ** As a result, MRT will be set to the volume weighted average MAT for that enclosure

AUD, RDD, MTD diffs due to new output variables.

eso small diffs in PMV, likely due to changes in CalcZoneMRT function.

Myoldmopar

This looks great to me! There is one comment that seems to keep the door open for more changes, but I think it's for another day. I'm testing locally to confirm but expect this to be ready to merge.

Myoldmopar · 2023-11-14T15:36:56Z

idd/Energy+.idd.in

-       \key ZoneAveraged
+       \key EnclosureAveraged


Key change, people!

Myoldmopar · 2023-11-14T15:44:22Z

idd/Energy+.idd.in

        \type object-list
        \object-list AllHeatTranSurfNames
  N99,  \field Angle Factor 99
        \type real
        \minimum 0.0
        \maximum 1.0
-  A102, \field Surface 100 Name
+  A101, \field Surface 100 Name


That's a lot of damage just for a field removal, but such is life!

Myoldmopar · 2023-11-14T15:46:19Z

src/EnergyPlus/AirflowNetwork/src/Solver.cpp

@@ -12805,7 +12805,8 @@ namespace AirflowNetwork {
            Tcomfort = CurveValue(state, ComfortHighTempCurveNum, OutDryBulb);
        }
        ComfortBand = -0.0028 * (100 - MaxPPD) * (100 - MaxPPD) + 0.3419 * (100 - MaxPPD) - 6.6275;
-        Toperative = 0.5 * (state.dataZoneTempPredictorCorrector->zoneHeatBalance(ZoneNum).MAT + state.dataHeatBal->ZoneMRT(ZoneNum));
+        Toperative = 0.5 * (state.dataZoneTempPredictorCorrector->zoneHeatBalance(ZoneNum).MAT +


Someday I wonder if we should rename the dataZoneTempPredictorCorrector member to something smaller. Would the increase in readability throughout the code make it worth the diffs? I think so actually. But obviously not here.

Myoldmopar · 2023-11-14T15:46:57Z

src/EnergyPlus/HeatBalanceAirManager.cc

+void calcMeanAirTemps(EnergyPlusData &state,
+                      Real64 const ZTAV,
+                      Real64 const airHumRatAvg,
+                      Real64 const MRT,


Myoldmopar · 2023-11-14T15:47:31Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+                ShowContinueError(state, "As a result, MRT will be set to MAT for that zone");
+            }
+            state.dataHeatBal->ZoneMRT(ZoneNum) = state.dataZoneTempPredictorCorrector->zoneHeatBalance(ZoneNum).MAT;
+        }


Does this mean something still needs to be cleaned out here?

Myoldmopar · 2023-11-21T16:00:40Z

src/EnergyPlus/ThermalComfort.cc

+        case DataHeatBalance::CalcMRT::EnclosureAveraged: {
+            int enclNum = state.dataHeatBal->space(thisPeople.spaceIndex).radiantEnclosureNum;
+            state.dataThermalComforts->RadTemp = state.dataViewFactor->EnclRadInfo(enclNum).MRT;


"So why didn't this PR just change this one line?", he asks as he runs away laughing maniacally.

Myoldmopar · 2023-11-21T16:02:10Z

src/Transition/CreateNewIDFUsingRulesV24_1_0.f90

+      ! So instead, let's just move forward with a new 4 character string and use that in this file and the future
+      ! If we get to version 100.1 and we are still using this Fortran transition then well....we can deal with it then
+      sVersionNum = '***'
+      sVersionNumFourChars='24.1'


...... how was this not already in there? That's .. ummm .. weird.

Myoldmopar · 2023-11-21T16:02:47Z

src/Transition/CreateNewIDFUsingRules_template.f90

+      ! So instead, let's just move forward with a new 4 character string and use that in this file and the future
+      ! If we get to version 100.1 and we are still using this Fortran transition then well....we can deal with it then
+      sVersionNum = '***'
+      sVersionNumFourChars='23.2'


No it should be fine I think.

Myoldmopar · 2023-11-21T16:03:09Z

src/Transition/InputRulesFiles/Rules23-2-0-to-24-1-0.md


-# Object Change: ObjectStartsWithP
+[PR#10244](https://github.com/NREL/EnergyPlus/pull/10244/)


Excellent instructions here. Thanks!

Myoldmopar · 2023-11-21T17:16:11Z

This is all good locally, getting this merged now. Thanks @mjwitte !

mjwitte added 5 commits September 26, 2023 14:47

MRT IDD updates plus some space-related cleanup

3051a11

MRT I/O ref updates plus some space-related cleanup

334f264

Cleanup CalcSurfaceWeightedMRT and CalcRadTemp

cc355f9

EnclosureAveraged and delete ZoneName

4e073b1

EnclosureAveraged and delete ZoneName

cbfa45d

mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Sep 26, 2023

mjwitte added this to the EnergyPlus 24.1 IOFreeze milestone Sep 26, 2023

mjwitte added 3 commits September 26, 2023 15:40

Delete scratch files

62a319c

EnclosureAveraged

06448e1

EnclosureAveraged and json field names

066ff56

nealkruis changed the title ~~Meant Radiant Temperature from Zone to Enclosure~~ Mean Radiant Temperature from Zone to Enclosure Sep 27, 2023

mjwitte added 5 commits September 27, 2023 14:33

Merge remote-tracking branch 'remotes/origin/develop' into 9377MRTPart2

35e5ce3

People MRTCalcType getEnumValue

557908f

Merge remote-tracking branch 'remotes/origin/develop' into 9377MRTPart2

85e2e91

Add enclosure MRT

d48a92f

Use enclosureMRT for thermal comfort

10a564d

rraustad reviewed Sep 30, 2023

View reviewed changes

mjwitte added 3 commits October 2, 2023 09:33

Setup enclosures earlier

7ee07cb

MRT calc refinement

4f6f7fe

Setup enclosures earlier

9e42b8d

mjwitte added the IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) label Oct 3, 2023

mjwitte added 4 commits October 3, 2023 12:33

Use enclosureMRT for interzone windows

ddaa321

Use enclosureMRT for operative temp

c56d921

BeginEnvironment init for enclosure MRT

f1059bd

Move MRT to zone/spaceHeatBalance add Space MRT output

9b9f419

mjwitte marked this pull request as ready for review October 5, 2023 19:29

mjwitte added 4 commits October 11, 2023 09:03

Merge remote-tracking branch 'remotes/origin/develop' into 9377MRTPart2

98b3af1

MRT transition

13c11ac

Update transition template

89df6cb

MRT unit test

481800c

mjwitte added 2 commits October 12, 2023 11:24

CalculateZoneMRT refinements

67516a6

MRT Docs

cd89804

mjwitte commented Oct 12, 2023

View reviewed changes

mjwitte requested review from Myoldmopar and nealkruis October 12, 2023 21:20

mjwitte added 2 commits October 30, 2023 15:00

Merge remote-tracking branch 'remotes/origin/develop' into 9377MRTPart2

0edf24a

format

3c59848

Myoldmopar assigned mjwitte Nov 8, 2023

mjwitte added 3 commits November 8, 2023 13:18

Merge remote-tracking branch 'remotes/origin/develop' into 9377MRTPart2

935bffb

Testfile cleanup

8eb0b2e

Error msg tweak

e3d51ef

mjwitte assigned Myoldmopar and unassigned mjwitte Nov 9, 2023

Myoldmopar approved these changes Nov 21, 2023

View reviewed changes

Myoldmopar merged commit d1dfe02 into develop Nov 21, 2023
15 checks passed

Myoldmopar deleted the 9377MRTPart2 branch November 21, 2023 17:16

mjwitte mentioned this pull request Dec 8, 2023

MRT calculations and radiant exchange calculations are not consistent #9631

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mean Radiant Temperature from Zone to Enclosure #10244

Mean Radiant Temperature from Zone to Enclosure #10244

mjwitte commented Sep 26, 2023 •

edited

rraustad Sep 30, 2023

mjwitte Oct 2, 2023

Myoldmopar Nov 14, 2023

mjwitte Nov 21, 2023

Myoldmopar Nov 21, 2023

mjwitte left a comment

mjwitte Oct 12, 2023

mjwitte Oct 12, 2023

Myoldmopar Nov 14, 2023

mjwitte Oct 12, 2023

mjwitte Oct 12, 2023

mjwitte Oct 12, 2023

mjwitte Oct 12, 2023

mjwitte Oct 12, 2023

Myoldmopar Nov 21, 2023

mjwitte Oct 12, 2023

mjwitte Oct 12, 2023

Myoldmopar Nov 21, 2023

mjwitte Oct 12, 2023

mjwitte commented Oct 12, 2023

Myoldmopar left a comment

Myoldmopar Nov 14, 2023

Myoldmopar Nov 14, 2023

Myoldmopar Nov 14, 2023

Myoldmopar Nov 14, 2023

Myoldmopar Nov 14, 2023

Myoldmopar Nov 21, 2023

Myoldmopar Nov 21, 2023

Myoldmopar Nov 21, 2023

Myoldmopar Nov 21, 2023

Myoldmopar commented Nov 21, 2023

		\paragraph{Space Mean Radiant Temperature {[}C{]}}\label{space-mean-radiant-temperature-c}
		\paragraph{Enclosure Mean Radiant Temperature {[}C{]}}\label{enclosure-mean-radiant-temperature-c}

		\note Watts/Area => Watts per Zone Floor Area -- enter the number to apply. Value * Floor Area = Lights
		\note Watts/Area => Watts per Floor Area -- enter the number to apply. Value * Floor Area = Lights

		thisAngFacList.SurfaceName(SurfNum) = state.dataIPShortCut->cAlphaArgs(SurfNum + 2);
		thisAngFacList.SurfaceName(SurfNum) = state.dataIPShortCut->cAlphaArgs(SurfNum + 1);

		tsky = state.dataHeatBal->ZoneMRT(ZoneNumAdj) +
		tsky = state.dataViewFactor->EnclRadInfo(enclNumAdj).MRT +


		# Object Change: ObjectStartsWithP
		[PR#10244](https://github.com/NREL/EnergyPlus/pull/10244/)

Mean Radiant Temperature from Zone to Enclosure #10244

Mean Radiant Temperature from Zone to Enclosure #10244

Conversation

mjwitte commented Sep 26, 2023 • edited

Pull request overview

Pull Request Author

Reviewer

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Oct 12, 2023

Myoldmopar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Myoldmopar commented Nov 21, 2023

mjwitte commented Sep 26, 2023 •

edited