Fix hint value assignment in SetupUnitConversion() and check if there are any diffs

[jcyuan2020]

Pull request overview

• Fixes Hint value assignment typo in SetupUnitConversion() #10260
• Trying to check if it would cause any diffs
• Actually, it does cause a noticeable diff in one of the LEED tables in 12 test files:

Diff Summary:

Before:

After:

Since the .hint value is used to look up the correct units to go when there are multiples, this should be a confirmed bug that has an impact and it needs to be fixed.

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[mjwitte]

@jcyuan2020 Ran 5ZoneAutoDXVAV.idf before and after, confirmed changes in table heading and values.
This looks good to go.
@Myoldmopar Tagx2!

[mjwitte]

Clearly the correct fix.

[mjwitte]

Confirmed that the unit test fails with develop.

[jcyuan2020]

@mjwitte @Myoldmopar It is suggested to get this pr merged before PR #10256.

[Myoldmopar]

Got it @jcyuan2020. I just merged a big PR, but it didn't appear to have any Git conflicts. I'll still build this branch with develop as of right now and make sure everything builds/tests happily before continuing.

[Myoldmopar]

This still passes happily locally. Let's get this one in now. Thanks @jcyuan2020