Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10287 - ExpandObjects - Incorrect warning about Boiler:HotWater having too many fields #10288

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Fix #10287 - ExpandObjects - Incorrect warning about Boiler:HotWater having too many fields #10288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ExpandObjects/epfilter.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1507,7 +1507,7 @@ PROGRAM epfilter
INTEGER,PARAMETER :: blrhwNameOff = 1
INTEGER,PARAMETER :: blrhwInletNodeOff = 11
INTEGER,PARAMETER :: blrhwOutletNodeOff = 12
INTEGER,PARAMETER :: blrhwLastFieldOff = 17
INTEGER,PARAMETER :: blrhwLastFieldOff = 18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra field was added, total number is 18


! Chiller:Electric:EIR (for use with HVACTemplate:Plant:Chiller:ObjectReference)
INTEGER,PARAMETER :: chleirNameOff = 1
Expand Down Expand Up @@ -2305,7 +2305,7 @@ SUBROUTINE SetUpObjectsToProcess(doGatherSurfaces)
CALL AddObjToProcess('HVACTemplate:Plant:MixedWaterLoop',.TRUE., mwpNameOff, mwpLdDistSchmOff, 17)
CALL AddObjToProcess('HVACTemplate:System:DedicatedOutdoorAir',.TRUE.,doasNameOff, doasHumidSetPtSchedNameOff, 46)
! Detailed Plant Objects
CALL AddObjToProcess('Boiler:HotWater',.FALSE., blrhwOutletNodeOff, blrhwLastFieldOff, 17)
CALL AddObjToProcess('Boiler:HotWater',.FALSE., blrhwOutletNodeOff, blrhwLastFieldOff, 18)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether I need to bump 17 to 18 here or not.

CALL AddObjToProcess('Chiller:Electric:EIR',.FALSE., chleirCondTypeOff, chleirLastFieldOff, 30)
CALL AddObjToProcess('Chiller:Electric:ReformulatedEIR',.FALSE., chlreirCondOutletNodeOff, chlreirLastFieldOff, 26)
CALL AddObjToProcess('CoolingTower:SingleSpeed',.FALSE., twrssOutletNodeOff, twrssLastFieldOff, 29)
Expand Down