Correct crash with DOAS VS DX coils and fix system name in Coil Sizing tables #10334

rraustad · 2023-12-15T22:45:12Z

Pull request overview

Fixes Multiple DOAS systems can report incorrect system type and name in Coil Sizing tables #10332
A user file with multiple DOAS systems using variable speed DX coolig coils did not run in EnergyPlus and when corrected showed incorrect HVAC Type and HVAC Name in Coil Details tables.

Reporting corrections:

HVAC Type and HVAC Name are reported for DOAS system
DOAS coil air flow is reported
System Sizing Method Concurrence method added Combination for when air loops used different sizing methods
TU heating coil air flow rate

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

rraustad

Walk-thru

rraustad · 2023-12-15T22:47:34Z

src/EnergyPlus/AirLoopHVACDOAS.cc

@@ -853,7 +853,6 @@ namespace AirLoopHVACDOAS {
        if (state.dataGlobal->BeginEnvrnFlag && this->MyEnvrnFlag) {
            bool ErrorsFound = false;
            Real64 rho;
-            state.dataSize->CurSysNum = this->m_OASystemNum;


Underlying problem with the table reporting issues. This line reset CurSysNum to CurOASysNum which confused table reports. The component variables CurSysNum and CurOASysNum are set in SizingAirLoopDOAS as:

state.dataSize->CurSysNum = state.dataHVACGlobal->NumPrimaryAirSys + this->m_AirLoopDOASNum + 1; state.dataSize->CurOASysNum = this->m_OASystemNum;

Whether these initializations should be moved to SimAirLoopHVACDOAS to emulate SimAirLoops is another question. I'm not sure these variables are used in anything other than sizing.

rraustad · 2023-12-15T22:50:25Z

src/EnergyPlus/Autosizing/HeatingCapacitySizing.cc

@@ -451,7 +451,7 @@ Real64 HeatingCapacitySizer::size(EnergyPlusData &state, Real64 _originalValue,

    this->selectSizerOutput(state, errorsFound);

-    if (this->isCoilReportObject && this->curSysNum <= state.dataHVACGlobal->NumPrimaryAirSys) {
+    if (this->isCoilReportObject) {


Many of these issues. The DOAS indexes are currently appended to the number of air loops (i.e., CurSysNum = 6 for a DOAS with 5 AirLoopHVAC objects). When code uses CurSysNum to access air loop arrays there is an access violation when DOAS components are sized. These subtle changes were made to get this defect file to run.

Interesting. Should we actually use a separate counter for DOAS systems rather than keeping them magically in line with the other air loops? That's something for later, but just curious how you'd like to proceed in the future.

We have CurZoneEqNum, CurSysNum, and CurOASysNum. I think we do need a CurDOASNum. While making this change I was also wondering what the long term fix was. Still not sure if if (this->isCoilReportObject && this->curDOASNum == 0) is any better than what is here now.

rraustad · 2023-12-15T22:50:51Z

src/EnergyPlus/ReportCoilSelection.cc

-                                                     c->airloopNum > 0 ? state.dataAirSystemsData->PrimaryAirSystems(c->airloopNum).Name : "N/A");
+                                                     c->airloopNum > 0 && c->airloopNum <= state.dataHVACGlobal->NumPrimaryAirSys
+                                                         ? state.dataAirSystemsData->PrimaryAirSystems(c->airloopNum).Name
+                                                         : "N/A");


DOAS index violation. The thing I don't like about the if (airloopNum < NumPrimaryAirSys) is that DOAS information is not reported. This is of course fixable.

rraustad · 2023-12-15T22:51:12Z

src/EnergyPlus/ReportCoilSelection.cc

@@ -543,7 +548,7 @@ void ReportCoilSelection::doAirLoopSetup(EnergyPlusData &state, int const coilVe
 {
    // this routine sets up some things for central air systems, needs to follow setting of an airloop num
    auto &c(coilSelectionDataObjs[coilVecIndex]);
-    if (c->airloopNum > 0 && allocated(state.dataAirSystemsData->PrimaryAirSystems)) {
+    if (c->airloopNum > 0 && c->airloopNum <= state.dataAirSystemsData->PrimaryAirSystems.size()) {


DOAS index violation within this block.

rraustad · 2023-12-15T22:51:40Z

src/EnergyPlus/ReportCoilSelection.cc

+            c->typeHVACname = "AirLoopHVAC:DedicatedOutdoorAirSystem";
+            int DOASSysNum = state.dataAirLoop->OutsideAirSys(c->oASysNum).AirLoopDOASNum;
+            c->userNameforHVACsystem = state.dataAirLoopHVACDOAS->airloopDOAS[DOASSysNum].Name;
+        } else if (c->airloopNum > 0 && c->zoneEqNum == 0) {


Correct Coil Sizing tables to report DOAS type and name correctly.

rraustad · 2023-12-15T22:51:55Z

src/EnergyPlus/ReportCoilSelection.cc

@@ -1276,7 +1286,8 @@ void ReportCoilSelection::setCoilCoolingCapacity(
    //    if ( c->zoneEqNum > 0 ) doZoneEqSetup( index );
    c->oASysNum = curOASysNum;

-    if (curSysNum > 0 && c->zoneEqNum == 0 && allocated(state.dataSize->FinalSysSizing) && allocated(SysSizPeakDDNum)) {
+    if (curSysNum > 0 && c->zoneEqNum == 0 && allocated(state.dataSize->FinalSysSizing) && allocated(SysSizPeakDDNum) &&
+        curSysNum <= state.dataHVACGlobal->NumPrimaryAirSys) {


DOAS index violation within this if block.

rraustad · 2023-12-15T22:53:15Z

src/EnergyPlus/UnitarySystem.cc

-                        state.dataAirLoop->AirLoopControlInfo(state.dataSize->CurSysNum).UnitarySysSimulating = false;
+                        if (state.dataSize->CurSysNum <= state.dataHVACGlobal->NumPrimaryAirSys) {
+                            state.dataAirLoop->AirLoopControlInfo(state.dataSize->CurSysNum).UnitarySysSimulating = false;
+                        }


Protect access array violation when CoilSystem is used in DOAS systems.

rraustad · 2023-12-15T22:54:06Z

src/EnergyPlus/VariableSpeedCoils.cc

+                        RatedAirVolFlowRateDes = state.dataSize->FinalSysSizing(state.dataSize->CurSysNum).DesMainVolFlow;
+                    } else {
+                        RatedAirVolFlowRateDes = 0.0;
+                    }


Add to VS DX coil sizing for coils in a DOAS. I did not update this code to use the sizing classes. Probably should have but was trying to get this file to run.

rraustad · 2023-12-16T00:06:30Z

Defect file results:

rraustad · 2023-12-17T00:28:29Z

src/EnergyPlus/DataSizing.hh

@@ -120,6 +120,7 @@ namespace DataSizing {
    // parameters for sizing
    constexpr int NonCoincident(1);
    constexpr int Coincident(2);
+    constexpr int Combination(3);


If 1 airloop on a DOAS system sizes coincident and others size noncoincident then reporting for System Sizing Method Concurrence needs an alternate notation.

rraustad · 2023-12-17T00:30:15Z

src/EnergyPlus/VariableSpeedCoils.cc

@@ -5014,6 +5043,8 @@ namespace VariableSpeedCoils {
            state.dataRptCoilSelection->coilSelectionReportObj->setCoilLvgAirTemp(state, varSpeedCoil.Name, varSpeedCoil.VarSpeedCoilType, SupTemp);
            state.dataRptCoilSelection->coilSelectionReportObj->setCoilLvgAirHumRat(
                state, varSpeedCoil.Name, varSpeedCoil.VarSpeedCoilType, SupHumRat);
+            state.dataRptCoilSelection->coilSelectionReportObj->setCoilAirFlow(
+                state, varSpeedCoil.Name, varSpeedCoil.VarSpeedCoilType, varSpeedCoil.RatedAirVolFlowRate, RatedAirFlowAutoSized);


Heating coils in OA systems were not reporting air flow in Coil Sizing tables. Or maybe it's just DOAS system, but there are times when air flow = -999 and this corrects that.

rraustad · 2023-12-17T18:22:50Z

5Zone_Unitary_HXAssistedCoil table diffs. Both develop and this branch used TermUnitSizing(this->curTermUnitSizingNum).AirVolFlow = 0.129526 to size the zone heating coil, but develop reported the FinalZoneSizing heating volume flow = 0.15108.

EnergyArchmage · 2024-01-16T16:57:58Z

I have reviewed the code changes here and they look good.

nrel-bot · 2024-02-14T00:09:18Z

@rraustad @Myoldmopar it has been 28 days since this pull request was last updated.

Myoldmopar

These look good to me, I'll double check locally with other develop changes, but expect this to merge soon if clean.

Myoldmopar · 2024-02-16T20:49:02Z

Table diffs are quite expected and reasonable. Otherwise this is happy and ready to merge. Thanks @rraustad

Get file to run and report system name

08733a7

rraustad added the Defect Includes code to repair a defect in EnergyPlus label Dec 15, 2023

rraustad commented Dec 15, 2023

View reviewed changes

Correct DOAS VS DX cooling coil sizing

aeec774

rraustad added 3 commits December 15, 2023 21:28

Add more DOAS logic

45147b7

Fill in Coil Sizing table air flow for OA heating coils

c80c5ee

Clean up warnings and add combined sizing methods

bb8981e

rraustad commented Dec 17, 2023

View reviewed changes

rraustad added 2 commits December 16, 2023 21:01

Revert change to loop counters

259cadd

Fix loop index max

2308f5f

rraustad added this to the EnergyPlus 24.1 milestone Jan 4, 2024

Myoldmopar approved these changes Feb 16, 2024

View reviewed changes

Myoldmopar merged commit 19484de into develop Feb 16, 2024
15 checks passed

Myoldmopar deleted the 10332-DOAS-incorrect-system-name-in-CoilDetails branch February 16, 2024 20:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct crash with DOAS VS DX coils and fix system name in Coil Sizing tables #10334

Correct crash with DOAS VS DX coils and fix system name in Coil Sizing tables #10334

rraustad commented Dec 15, 2023 •

edited

rraustad left a comment

rraustad Dec 15, 2023

rraustad Dec 15, 2023 •

edited

Myoldmopar Feb 16, 2024

rraustad Feb 16, 2024

rraustad Dec 15, 2023 •

edited

rraustad Dec 15, 2023

rraustad Dec 15, 2023

rraustad Dec 15, 2023

rraustad Dec 15, 2023

rraustad Dec 15, 2023

rraustad commented Dec 16, 2023

rraustad Dec 17, 2023 •

edited

rraustad Dec 17, 2023

rraustad commented Dec 17, 2023 •

edited

EnergyArchmage commented Jan 16, 2024

nrel-bot commented Feb 14, 2024

Myoldmopar left a comment

Myoldmopar commented Feb 16, 2024

Correct crash with DOAS VS DX coils and fix system name in Coil Sizing tables #10334

Correct crash with DOAS VS DX coils and fix system name in Coil Sizing tables #10334

Conversation

rraustad commented Dec 15, 2023 • edited

Pull request overview

Pull Request Author

Reviewer

rraustad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad Dec 15, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad Dec 15, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Dec 16, 2023

rraustad Dec 17, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Dec 17, 2023 • edited

EnergyArchmage commented Jan 16, 2024

nrel-bot commented Feb 14, 2024

Myoldmopar left a comment

Choose a reason for hiding this comment

Myoldmopar commented Feb 16, 2024

rraustad commented Dec 15, 2023 •

edited

rraustad Dec 15, 2023 •

edited

rraustad Dec 15, 2023 •

edited

rraustad Dec 17, 2023 •

edited

rraustad commented Dec 17, 2023 •

edited