Correct AFN node temperature compatible with zone air temperature

[lgu1234]

Pull request overview

• Fixes AFN node temperature is very different than zone air temperature #10238
• DESCRIBE PURPOSE OF THIS PULL REQUEST

The defect file shows that the "crawlspace_unit1" AFN node temperature follows the "living_unit1" zone air temperature which is much different than its corresponding actual zone air temperature. A workaround created by @lgu1234 is to swap the order of the AFN:Zone object in the input file.

The fix provided a correct AFN zone index. After fix, AFN node temperatures are compatible with zone air temperature.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• [X ] Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• [ X] Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• [X ] Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[lgu1234]

The zone number should be AFN zone index, instead of zone number from Zone object.

[Myoldmopar]

OK I see it. This accesses the right element of the AFN Node Data array. Good.

[jasondegraw]

@lgu1234 @Myoldmopar This fix looks correct to me. I wish the unit test was a bit shorter and didn't require so much in the way of static data, but I don't think there's a way around that.

[Myoldmopar]

This is a fine change, @lgu1234 . Thanks for confirming @jasondegraw. I pulled develop in and tested it locally with no problem. Merging this.