Fix Window Heat Transfer and Solar Out Window output reporting #10444

mjwitte · 2024-03-20T21:04:44Z

Pull request overview

Fixes "Surface Window Net Heat Transfer Energy" does not account for all heat transfer across the windows #10333
Correct "Surface Inside Face Initial Transmitted Diffuse Transmitted Out Window Solar Radiation Rate" (state.dataHeatBal->SurfWinInitialDifSolInTransReport, SurfWinInitialDifSolInTrans) and "Surface Window Shortwave from Zone Back Out Window Heat Transfer Rate" (state.dataSurface->SurfWinLossSWZoneToOutWinRep) to be (1-Reflected) solar. Previously, these were calculated using the diffuse transmittance which omits the solar absorbed in the glass on the way out.
When using full interior solar distribution, some direct beam solar can leave the zone when it is incident on the inside face of a window (interior or exterior). This component is now added to "Surface Window Shortwave from Zone Back Out Window Heat Transfer Rate".
Correct "Surface Window Net Heat Transfer Rate" and related outputs to subtract "Surface Inside Face Initial Transmitted Diffuse Transmitted Out Window Solar Radiation Rate". Previously, this term was omitted, so the window heat gain was overstated. Related outputs include "Surface Window Heat Gain Rate/Energy" and "Surface Window Heat Loss Rate/Energy". Note that there may be significant changes in these outputs for highly glazed enclosures.
Fixes eio output for WindowConstruction to write the values for Solar Transmittance at Normal Incidence and Visible Transmittance at Normal Incidence. Previously, the format did not have enough terms, so the last two values were not written. This happened in v22.1 when "Conductance (Before Adjusted) {W/m2-K}" and "Convection Coefficient Adjustment Ratio" were added in Post release I/O changes of the simple glazing frame feature #9117.

Expected Diffs

NO mtr diffs because none of the impacted calculations are actually used in the heat balance, they are all side calcs used to generate various output variables.
eio diffs due to missing terms in the WindowConstruction report. And equivalent table diffs in the Initialization Summary report, e.g. PurchAirWindowBlind:

- WindowConstruction,WIN-CON-SINGLEPANE,5,1,VerySmooth,5.894,5.894,1.000,0.919
+ WindowConstruction,WIN-CON-SINGLEPANE,5,1,VerySmooth,5.894,5.894,1.000,0.919,0.900,0.900

eso diffs for any of the affected output variables
Table diffs for the Sensible Heat Gain Summary, because Surface Window Heat Gain Energy (and Loss) are used for the "Window Heat Addition/Loss" columns in this report, e.g. percent diff output for _5ZoneAirCooled_annual:

ToDo List

Unit test
I/O Ref updates, maybe Engineering Ref?
Confirm that the correct reflectance values have been used for the various window types (normal, complex, and equivalent layer).
Demonstrate solar and energy balances with defect file.
Check results for all variations of solar distribution (so far FullExterior looks good).
Demonstrate solar and energy balances with defect file.
Some minor refactoring to avoid extra multiplications.
A separate no-diff PR with some additional code cleanup (e.g. reduced variable scope, reference assignments, avoid duplicate code where possible, etc.).

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Reviewer

This will not be exhaustively relevant to every PR.

…WinInitialDifSolInTrans

mjwitte · 2024-03-21T14:34:44Z

Tagging this for v24.1, because the change in the Window Heat Gain/Loss outputs is dramatic for highly glazed spaces. But there is still some QA work to be done on these changes, so it may need to wait for v24.2. There is a small output change that can be reverted if this is a go for v24.1.

rraustad · 2024-03-21T14:38:07Z

Could you provide a walk-thru, and discuss the "* transmittance" versus "* (1 - Reflectance)" changes and why.

shorowit · 2024-03-21T15:03:05Z

I'm really looking forward to these improvements. We've been providing disaggregated heating/cooling loads by component for many years and have never gotten the sum of all components to perfectly match the total building load, with windows being the primary culprit.

It would be nice if the somewhere in the documentation it clearly stated which individual heat transfer components add up to the total window heat transfer.

shorowit · 2024-03-21T15:04:40Z

I'm also happy to test these changes across a range of our residential models, let me know when you think it is worth testing.

rraustad · 2024-03-21T16:28:29Z

I noticed this in CppCheck. If no other changes this can be cleaned out later.
https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/SolarShading.cc#L6734-L6737

mjwitte · 2024-03-21T16:55:53Z

I noticed this in CppCheck. If no other changes this can be cleaned out later. https://github.com/NREL/EnergyPlus/blob/develop/src/EnergyPlus/SolarShading.cc#L6734-L6737

Well, that's only been in there for 3 yrs. Removed.

mjwitte · 2024-03-21T18:44:58Z

Could you provide a walk-thru, and discuss the "* transmittance" versus "* (1 - Reflectance)" changes and why.

Here's the I/O Reference definition for Window Heat Gain for an unshaded window:

The total heat flow to the zone from the glazing, frame and divider of an exterior window when the total
heat flow is positive.
For a window without an interior shading device, this heat flow is equal to:
• [Surface Window Transmitted Solar Radiation Rate (see definition, above)]
• [Convective heat flow to the zone from the zone side of the glazing]
• [Net IR heat flow to the zone from zone side of the glazing]
• [Short-wave radiation from zone transmitted back out the window]
• [Convection to zone from window frame and divider, if present]
Here, short-wave radiation is that from lights and diffuse interior solar radiation.
The total window heat flow can also be thought of as the sum of the solar and conductive gain to the
zone from the window.

The first term, solar transmitted into the zone, as well as the convective and IR heat flow, are at the boundary volume of the inside face of the window surface. So the shortwave that leaves the zone should also be at the inside face, thus OutgoingSolarOrShortwave*(1-Reflectance). Any energy absorbed in the glass on the way in or out will be accounted for in the glass temperature that impacts the convective and IR heat flow.

Stepping back from the heat gain, I first tried to balance just the solar components, expecting that:
Zone Windows Total Transmitted Solar Radiation Energy = Sum Opaque Surface Inside Face Solar Radiation Heat Gain Energy + Sum Surface Window Shortwave from Zone Back Out Window Heat Transfer Energy + Sum Surface Inside Face Initial Transmitted Diffuse Transmitted Out Window Solar Radiation Energy.

Here's the solar balance before and after for the defect file (which is a box with four walls that are nearly 100% glazing) with FullExterior solar distribution:
Develop:

This Branch:

Not perfect, but balancing within 0.2% is much better than 8%.

Then I tried the same with FullInteriorAndExterior, and the imbalance ranges from 0.8 to 6%, highest in the winter months. Looks like we need yet another window variable to track beam solar that leaves out a window.

rraustad · 2024-03-21T19:20:32Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-                                                                           state.dataConstruction->Construct(surface.Construction).TransDiff;
+                state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum) =
+                    state.dataHeatBal->EnclSolQSWRad(surface.SolarEnclIndex) * surface.Area *
+                    (1 - state.dataConstruction->Construct(surface.Construction).ReflectSolDiffBack);


Isn't part of (1-ReflectSolDiffBack) absorbed by the window on the way out? and therefore doesn't make it out?

Isn't part of (1-ReflectSolDiffBack) absorbed by the window on the way out? and therefore doesn't make it out?

Yes, some is absorbed. If your boundary volume is the inside face, then (1-Reflected) has already made it out. If some gets absorbed, then that's accounted for in the convective/radiative exchange for the glass.

mjwitte

First walkthru.

mjwitte · 2024-03-21T18:58:37Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-                // Calculate window heat gain for TDD:DIFFUSER since this calculation is usually done in WindowManager
-                state.dataSurface->SurfWinHeatGain(SurfNum) =


Move this down, because all of the components are being calculated twice.

mjwitte · 2024-03-21T18:58:42Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

-                state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum) = state.dataHeatBal->EnclSolQSWRad(surface.SolarEnclIndex) * surface.Area *
-                                                                           state.dataConstruction->Construct(surface.Construction).TransDiff;
+                state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum) =
+                    state.dataHeatBal->EnclSolQSWRad(surface.SolarEnclIndex) * surface.Area *
+                    (1 - state.dataConstruction->Construct(surface.Construction).ReflectSolDiffBack);


Here and below, calcs just for TDD:Diffuser. Switch this component to use (1-ReflectSolDiffBack) instead of TransDiff.

mjwitte · 2024-03-21T19:00:58Z

src/EnergyPlus/HeatBalanceSurfaceManager.cc

+                state.dataSurface->SurfWinHeatGain(SurfNum) =
+                    state.dataSurface->SurfWinTransSolar(SurfNum) + state.dataSurface->SurfWinGainConvGlazToZoneRep(SurfNum) +
+                    state.dataSurface->SurfWinGainIRGlazToZoneRep(SurfNum) - state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum) -
+                    surface.Area * state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(SurfNum);


Calculate SurfWinHeatGain here, after all of the components have been calculated to avoid duplicate calcs. Also add the - surface.Area * state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(SurfNum) term.

mjwitte · 2024-03-21T19:01:21Z

src/EnergyPlus/SolarShading.cc

@@ -6731,10 +6731,6 @@ void CalcInteriorSolarDistribution(EnergyPlusData &state)
                                                  (AbsBlDiffBack * RGlDiffFront / (1.0 - RhoBlDiffBack * RGlDiffFront)) *
                                                      (RGlFront * TBlBmBm * RhoBlBack + TBlBmDiff);
                                state.dataSolarShading->SurfWinExtBeamAbsByShadFac(SurfNum) = AbsShade * CosInc * SunLitFract * InOutProjSLFracMult;
-                                if (state.dataEnvrn->Month == 7 && state.dataEnvrn->DayOfMonth == 21 && state.dataGlobal->HourOfDay == 8) {


Remove old debug code.

mjwitte · 2024-03-21T19:02:49Z

src/EnergyPlus/SolarShading.cc

+                            // Should be just total less reflected
+                            Real64 DifSolarTransIntoW = WinDifSolarTrans_Factor - DifSolarReflW;

                            // Accumulate transmitted diffuse solar for reporting
-                            state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(HeatTransSurfNum) += DifSolarTransW * per_HTSurfaceArea;
+                            state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(HeatTransSurfNum) += DifSolarTransIntoW * per_HTSurfaceArea;


Use total incoming minus reflected for initial solar out window. Similar calcs appear in multiple places for different window types.

mjwitte · 2024-03-21T19:25:14Z

src/EnergyPlus/WindowComplexManager.cc

-                TransDiff;
-            state.dataSurface->SurfWinHeatGain(SurfNum) -= state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum);
+                (1 - ReflDiff);
+            state.dataSurface->SurfWinHeatGain(SurfNum) -=
+                (state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum) +
+                 state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(SurfNum) * state.dataSurface->Surface(SurfNum).Area);


Use (1-Reflectance) for Shortwave from Zone Out Window, and also subtract the Initial Diffuse Out Window term from SurfWinHeatGain. This appears in multiple places.

mjwitte · 2024-03-21T19:26:28Z

src/EnergyPlus/WindowManager.cc

@@ -7371,7 +7379,7 @@ namespace WindowManager {
                        state.dataConstruction->Construct(ThisNum).VisTransNorm = TransVisNorm;
                        state.dataConstruction->Construct(ThisNum).SolTransNorm = TransSolNorm;

-                        static constexpr std::string_view Format_700(" WindowConstruction,{},{},{},{},{:.3R},{:.3R},{:.3R},{:.3R}\n");
+                        static constexpr std::string_view Format_700(" WindowConstruction,{},{},{},{},{:.3R},{:.3R},{:.3R},{:.3R},{:.3R},{:.3R}\n");


Extend format so that Solar and Visible Transmittance values are written to eio for the WindowConstruction report.

…olarOutputs

mjwitte

Walkthru part 2. This still needs some unit tests, but I'm marking this ready for review. I'll add another comment showing some before/after results for solar and energy balance.

mjwitte · 2024-04-26T16:15:36Z

doc/input-output-reference/src/overview/group-thermal-zone-description-geometry.tex


-\subsubsection{Surface Window Heat Gain Energy {[}J{]}}\label{surface-window-heat-gain-energy-j}
+\subsubsection{Surface Window Net Heat Transfer Energy {[}J{]}}\label{surface-window-net-heat-transfer-rate-j}


Update this section use actual output variable names for the components, add missing components, and delete duplicate list of components. Reviewers, please read these doc changes carefully to see if they make sense.

mjwitte · 2024-04-26T16:16:51Z

doc/input-output-reference/src/overview/group-thermal-zone-description-geometry.tex

@@ -3803,7 +3765,7 @@ \subsubsection{Surface Storm Window On Off Status {[]}}\label{surface-storm-wind

 \subsubsection{Surface Inside Face Initial Transmitted Diffuse Transmitted Out Window Solar Radiation Rate {[}W{]}}\label{surface-inside-face-initial-transmitted-diffuse-transmitted-out-window-solar-radiation-rate-w}

-As of Version 2.1, the diffuse solar transmitted through exterior windows that is initially distributed to another window in the zone and transmitted out of the zone through that window. For exterior windows, this transmitted diffuse solar is ``lost'' to the exterior environment For interior windows, this transmitted diffuse solar is distributed to heat transfer surfaces in the adjacent zone, and is part of the Surface Inside Face Initial Transmitted Diffuse Absorbed Solar Radiation Rate for these adjacent zone surfaces.
+As of Version 2.1, the diffuse solar transmitted through exterior windows that is initially distributed to another window in the zone and transmitted out of the zone through the inside face of the window. Some of this will be absorbed in the window layers and some will be transmitted through. For exterior windows, transmitted diffuse solar is ``lost'' to the exterior environment. For interior windows, this transmitted diffuse solar is distributed to heat transfer surfaces in the adjacent zone, and is part of the Surface Inside Face Initial Transmitted Diffuse Absorbed Solar Radiation Rate for these adjacent zone surfaces.


Update the description for Surface Inside Face Initial Transmitted Diffuse Transmitted Out Window Solar Radiation Rate to explain that the boundary volume is the inside face of the glass or window assembly.

mjwitte · 2024-04-26T16:17:39Z

doc/input-output-reference/src/overview/group-thermal-zone-description-geometry.tex


 \subsubsection{Surface Window Inside Face Frame and Divider Zone Heat Gain Rate {[}W{]}}\label{surface-window-inside-face-frame-and-divider-zone-heat-gain-rate-w}

-This is the heat transfer from any frames and/or dividers to the zone in watts. This output variable is the term called ``{[}Conduction to zone from window frame and divider, if present{]}'' under the description above for Surface Window Heat Gain Rate output variable. (The word ``conduction'' here is used because the models is simplified compared to the complexities of surface convection and radiation.)
+This is the convective heat transfer from any frames and/or dividers to the zone in watts. Negative values imply heat flow to the exterior. The Surface Window Frame Inside Temperature and Surface Window Divider Inside Temperature are computed from a heat balance on the frame/divider that includes solar radiation, long-wave radiation, convection, and conduction. The frame/divider is then included in the zone heat balance via convection at this inside temperature. See Engineering Reference ``Window Frame and Divider Calculation'' for more details.


Add some clarification to Surface Window Inside Face Frame and Divider Zone Heat Gain Rate.

mjwitte · 2024-04-26T16:18:40Z

doc/input-output-reference/src/overview/group-thermal-zone-description-geometry.tex

@@ -3819,11 +3781,11 @@ \subsubsection{Surface Window Inside Face Glazing Net Infrared Heat Transfer Rat

 \subsubsection{Surface Window Shortwave from Zone Back Out Window Heat Transfer Rate {[}W{]}}\label{surface-window-shortwave-from-zone-back-out-window-heat-transfer-rate-w}

-This is the short-wave radiation heat transfer from the zone back out the window in watts. This is a measure of the diffuse short-wave light (from reflected solar and electric lighting) that leave the zone through the window. This output variable is the term called ``{[}Short-wave radiation from zone transmitted back out the window{]}'' under the description above for Surface Window Heat Gain Rate output variable.
+This is the short-wave radiation heat transfer from the zone back out the inside face of the window in watts. This is a measure of the diffuse short-wave light (from beam and diffuse solar and electric lighting) that leaves the zone through the window.


Update Surface Window Shortwave from Zone Back Out Window Heat Transfer Rate to add interior incident beam (from FullInterior solar distribution) and explain the inside face boundary volume.

mjwitte · 2024-04-26T16:20:17Z

src/EnergyPlus/SolarShading.cc

-                                Real64 AbsBeamTotWin = 0.0; // Sum of window glass layer beam solar absorptances
+                                Real64 TransBeamWin = 0.0;           // Beam solar transmittance of a window
+                                Real64 AbsBeamTotWin = 0.0;          // Sum of window glass layer beam solar absorptances
+                                Real64 backSurfBeamSolInTrans = 0.0; // Fraction of BeamSolarRad transmitted out through window inside face [W]


Track interior beam solar that enters a back surface that's a window.

mjwitte · 2024-04-26T16:22:09Z

src/EnergyPlus/WindowEquivalentLayer.cc

-        state.dataSurface->SurfWinTransSolar(SurfNum) + ConvHeatGainWindow + NetIRHeatGainWindow + ConvHeatFlowNatural;
+        state.dataSurface->SurfWinTransSolar(SurfNum) + ConvHeatGainWindow + NetIRHeatGainWindow + ConvHeatFlowNatural -
+        (state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum) +
+         state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(SurfNum) * state.dataSurface->Surface(SurfNum).Area);


Subtract missing solar leaving components from SurfWinHeatGain for equivalent layer windows.

mjwitte · 2024-04-26T16:26:23Z

src/EnergyPlus/WindowManager.cc

-            state.dataSurface->SurfWinHeatGain(SurfNum) -= state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum);
+                    (1 - reflDiff) +
+                state.dataHeatBalSurf->SurfWinInitialBeamSolInTrans(SurfNum);
+            state.dataSurface->SurfWinHeatGain(SurfNum) -=


Subtract missing solar leaving components from SurfWinHeatGain for regular windows.

mjwitte · 2024-04-26T16:27:01Z

src/EnergyPlus/WindowComplexManager.cc

-            state.dataSurface->SurfWinHeatGain(SurfNum) -= state.dataSurface->SurfWinLossSWZoneToOutWinRep(SurfNum);
+                    (1 - ReflDiff) +
+                state.dataHeatBalSurf->SurfWinInitialBeamSolInTrans(SurfNum);
+            state.dataSurface->SurfWinHeatGain(SurfNum) -=


Subtract missing solar leaving components from SurfWinHeatGain for complex windows.

…olarOutputs

mjwitte · 2024-04-26T16:44:28Z

See #10444 (comment) for before/after results with FullExterior solar distribution. Zip of working folder attached (with idfs, outputs, and xlsx).
After Fixes 5-Final.zip

Results after fix for FullInteriorAndExterior. Not perfect, but all within 1% balance. Results are similar for FullInteriorAndExteriorWithReflections.

shorowit · 2024-04-29T14:56:19Z

I tested this on one of our residential files and, using the output variables described in the documentation, got excellent agreement between the individual window heat transfer components and the net heat transfer energy. Looks good to me, thanks @mjwitte!

…nts in NREL/EnergyPlus#10444.

Myoldmopar

I'm going to hold from approve/reject to hear back about the parentheses issue. Otherwise this looks fine.

Myoldmopar · 2024-04-29T16:12:41Z

src/EnergyPlus/SolarShading.cc

@@ -6731,10 +6731,6 @@ void CalcInteriorSolarDistribution(EnergyPlusData &state)
                                                  (AbsBlDiffBack * RGlDiffFront / (1.0 - RhoBlDiffBack * RGlDiffFront)) *
                                                      (RGlFront * TBlBmBm * RhoBlBack + TBlBmDiff);
                                state.dataSolarShading->SurfWinExtBeamAbsByShadFac(SurfNum) = AbsShade * CosInc * SunLitFract * InOutProjSLFracMult;
-                                if (state.dataEnvrn->Month == 7 && state.dataEnvrn->DayOfMonth == 21 && state.dataGlobal->HourOfDay == 8) {


Myoldmopar · 2024-05-01T20:52:54Z

src/EnergyPlus/SolarShading.cc

@@ -12603,7 +12618,7 @@ void CalcInteriorWinTransDifSolInitialDistribution(EnergyPlusData &state,

                // Accumulate transmitted diffuse solar for reporting
                state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(HeatTransSurfNum) +=
-                    (DifSolarTransW / state.dataSurface->Surface(HeatTransSurfNum).Area);
+                    (SolarTrans_ViewFactor - DifSolarReflW / state.dataSurface->Surface(HeatTransSurfNum).Area);


Are the parentheses wrong on this one? It is different from the others.

@Myoldmopar You are right, the parentheses are wrong. It seem that it should be:
(SolarTrans_ViewFactor - DifSolarReflW) / state.dataSurface->Surface(HeatTransSurfNum).Area;
I did not run example to confirm this. However, there are other parts using the same equation:

EnergyPlus/src/EnergyPlus/SolarShading.cc

Lines 12441 to 12442 in f3c55b3

state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(HeatTransSurfNum) +=

(SolarTrans_ViewFactor - DifSolarReflW) / state.dataSurface->Surface(HeatTransSurfNum).Area;

and

EnergyPlus/src/EnergyPlus/SolarShading.cc

Lines 12511 to 12512 in f3c55b3

state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(HeatTransSurfNum) +=

(SolarTrans_ViewFactor - DifSolarReflW) / state.dataSurface->Surface(HeatTransSurfNum).Area;

Thanks, good catch! Fixed. This line is in a section of code that is distributing initial diffuse from an interior window to another window in the receiving zone that has a shading device. This is not currently covered by unit or integration tests. Hoping to improve the coverage.

…olarOutputs

vidanovic

I have no further comments. Approving this merge.

Myoldmopar · 2024-05-03T13:51:30Z

Diffs don't look to have changed since before, and everything is happy on CI. Thanks for fixing the parentheses and adding the some extra testing. Let's call this one done. Thanks @mjwitte and @rraustad and @vidanovic!

mjwitte added 3 commits March 20, 2024 15:37

SurfWinInitialDifSolInTrans=(1-Reflected)

b99e5eb

SurfWinLossSWZoneToOutWinRep-(1-Reflected), SurfWinHeatGain less Surf…

c7220b3

…WinInitialDifSolInTrans

Unit test fix

ffb75ff

mjwitte added Defect Includes code to repair a defect in EnergyPlus OutputChange Code changes output in such a way that it cannot be merged after IO freeze labels Mar 20, 2024

mjwitte modified the milestones: EnergyPlus 24.2 IOFreeze, EnergyPlus 24.1 Mar 21, 2024

Remove debug code

9c21393

mjwitte added 3 commits March 21, 2024 12:18

Simplify TDD Diffuser SurfWinHeatGain

ca72a10

Simplify TDD Diffuser SurfWinHeatGain

5afec37

Revert additional outputs

11c924a

mjwitte removed the OutputChange Code changes output in such a way that it cannot be merged after IO freeze label Mar 21, 2024

rraustad reviewed Mar 21, 2024

View reviewed changes

mjwitte commented Mar 21, 2024

View reviewed changes

mjwitte modified the milestones: EnergyPlus 24.1, EnergyPlus 24.2 IOFreeze Mar 25, 2024

Merge remote-tracking branch 'remotes/origin/develop' into WindowAndS…

cad0ad2

…olarOutputs

mjwitte mentioned this pull request Apr 4, 2024

"Surface Window Net Heat Transfer Energy" does not account for all heat transfer across the windows #10333

Closed

3 tasks

mjwitte added 4 commits April 12, 2024 16:04

Merge remote-tracking branch 'remotes/origin/develop' into WindowAndS…

080f45a

…olarOutputs

SurfWinInitialBeamSolInTrans for unshaded windows

5dec1e7

format

a4e42cb

SurfWinInitialBeamSolInTrans for all window types

60cc28b

mjwitte added 5 commits April 23, 2024 13:41

Merge remote-tracking branch 'remotes/origin/develop' into WindowAndS…

b376b3e

…olarOutputs

code cleanup

0a4559f

Window heat gain I/O Ref

7195ea8

Merge remote-tracking branch 'remotes/origin/develop' into WindowAndS…

01c1ae5

…olarOutputs

Skeleton unit test

483dbcb

mjwitte commented Apr 26, 2024

View reviewed changes

mjwitte marked this pull request as ready for review April 26, 2024 16:28

mjwitte requested review from vidanovic and Myoldmopar April 26, 2024 16:28

Merge remote-tracking branch 'remotes/origin/develop' into WindowAndS…

f3c55b3

…olarOutputs

shorowit added a commit to NREL/OpenStudio-HPXML that referenced this pull request Apr 29, 2024

Improves window component load calculation, uses EnergyPlus improveme…

5382bf1

…nts in NREL/EnergyPlus#10444.

shorowit mentioned this pull request Apr 29, 2024

Improves window component loads NREL/OpenStudio-HPXML#1699

Draft

7 tasks

Myoldmopar self-assigned this Apr 30, 2024

Myoldmopar reviewed May 1, 2024

View reviewed changes

Merge remote-tracking branch 'remotes/origin/develop' into WindowAndS…

363c1d9

…olarOutputs

vidanovic approved these changes May 2, 2024

View reviewed changes

mjwitte added 2 commits May 2, 2024 16:51

Repairs

1713f2d

Initial unit test

1d8183e

Myoldmopar merged commit e0b62ad into develop May 3, 2024
15 checks passed

Myoldmopar deleted the WindowAndSolarOutputs branch May 3, 2024 13:51

		// Calculate window heat gain for TDD:DIFFUSER since this calculation is usually done in WindowManager
		state.dataSurface->SurfWinHeatGain(SurfNum) =


		\subsubsection{Surface Window Heat Gain Energy {[}J{]}}\label{surface-window-heat-gain-energy-j}
		\subsubsection{Surface Window Net Heat Transfer Energy {[}J{]}}\label{surface-window-net-heat-transfer-rate-j}

	state.dataHeatBalSurf->SurfWinInitialDifSolInTrans(HeatTransSurfNum) +=
	(SolarTrans_ViewFactor - DifSolarReflW) / state.dataSurface->Surface(HeatTransSurfNum).Area;

Fix Window Heat Transfer and Solar Out Window output reporting #10444

Fix Window Heat Transfer and Solar Out Window output reporting #10444

Conversation

mjwitte commented Mar 20, 2024 • edited Loading

Pull request overview

Expected Diffs

ToDo List

Pull Request Author

Reviewer

mjwitte commented Mar 21, 2024

rraustad commented Mar 21, 2024

shorowit commented Mar 21, 2024

shorowit commented Mar 21, 2024

rraustad commented Mar 21, 2024

mjwitte commented Mar 21, 2024

mjwitte commented Mar 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Apr 26, 2024

shorowit commented Apr 29, 2024

Myoldmopar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vidanovic left a comment

Choose a reason for hiding this comment

Myoldmopar commented May 3, 2024

mjwitte commented Mar 20, 2024 •

edited

Loading