Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Humidifier:Steam:Gas VariableInletWaterTemperature option #10463

Merged
merged 4 commits into from Apr 11, 2024

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Apr 10, 2024

Pull request overview

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@shorowit shorowit added the Defect Includes code to repair a defect in EnergyPlus label Apr 10, 2024
@shorowit shorowit added this to the EnergyPlus 24.2 IOFreeze milestone Apr 10, 2024
@shorowit shorowit self-assigned this Apr 10, 2024
@Myoldmopar Myoldmopar self-assigned this Apr 10, 2024
@Myoldmopar
Copy link
Member

Everything is testing happily locally, if CI is good this can go right in.

@@ -82,6 +82,8 @@ namespace Humidifiers {
Variable,
Num
};
static constexpr std::array<std::string_view, static_cast<int>(InletWaterTemp::Num)> inletWaterTempsUC = {"FixedInletWaterTemperature",
"VariableInletWaterTemperature"};
Copy link
Contributor

@rraustad rraustad Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inletWaterTempsUC? doesn't look UC.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inletWaterTempsUC? doesn't look UC.

Was I supposed to actually fix them or something?

Thanks @rraustad :)

@Myoldmopar
Copy link
Member

Good now. :) Thanks again @rraustad. Merging.

@Myoldmopar Myoldmopar merged commit 8c14f4b into develop Apr 11, 2024
15 checks passed
@Myoldmopar Myoldmopar deleted the humidifier_bugfix branch April 11, 2024 15:43
@Myoldmopar
Copy link
Member

And thanks for the initial fix @shorowit !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants