New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Humidifier:Steam:Gas
VariableInletWaterTemperature option
#10463
Conversation
Everything is testing happily locally, if CI is good this can go right in. |
src/EnergyPlus/Humidifiers.hh
Outdated
@@ -82,6 +82,8 @@ namespace Humidifiers { | |||
Variable, | |||
Num | |||
}; | |||
static constexpr std::array<std::string_view, static_cast<int>(InletWaterTemp::Num)> inletWaterTempsUC = {"FixedInletWaterTemperature", | |||
"VariableInletWaterTemperature"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inletWaterTempsUC? doesn't look UC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inletWaterTempsUC? doesn't look UC.
Was I supposed to actually fix them or something?
Thanks @rraustad :)
Good now. :) Thanks again @rraustad. Merging. |
And thanks for the initial fix @shorowit ! |
Pull request overview
NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE
Pull Request Author
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Reviewer
This will not be exhaustively relevant to every PR.