Implement new coupled basement simulation model

[mitchute]

Pull request extending zone-slab coupling work to zone-basement coupling.

[mitchute]

@mjwitte I can update that. I think @Myoldmopar fixed a few things in that file and renamed it ZoneCoupledGroundHTBasement.idf, so this file is going to go away. I just noticed that it is still there. Nevertheless, this change should apply to both.

[mjwitte]

@mmAtTs @Myoldmopar Are you planning a similar name change for the slab
examples? I noticed they still have version=8.1, the new
ZoneCoupledGroundHTBasement.idf is 8.2.

Can we come up with a better set of inputs here?

 5,                       !- Kusuda-Achenbach Average Surface 

Temperature {C}
0, !- Kusuda-Achenbach Average Amplitude of
Surface Temperature {C}
0, !- Kusuda-Achenbach Phase Shift of Minimum
Surface Temperature {days}

When I ran this and got near-zero cooling energy (probably because of
the above inputs) I was curious about the geometry of the building so I
opened it in SketchUp Legacy OS Plugin and saw that two of the walls
were showing white which usually means they are backwards. Table output
shows no north area, and double the south area. So, the north walls are
backwards.

Ran the example file as-is, without horiz insul, and without any
insulation. Heating energy use went up - that's good. That's all for now.

On 11/10/2014 12:45 PM, Matt Mitchell wrote:

@mjwitte https://github.com/mjwitte I can update that. I think
@Myoldmopar https://github.com/Myoldmopar fixed a few things in that
file and renamed it ZoneCoupledGroundHTBasement.idf, so this file is
going to go away. I just noticed that it is still there. Nevertheless,
this change should apply to both.

—
Reply to this email directly or view it on GitHub
#4514 (comment).

[mitchute]

@mjwitte I wasn't planning on changing the names, but I'm open to it. These latest commits should address the issues you pointed out, along with a few others I discovered.

[mjwitte]

@mmAtTs @Myoldmopar Seems we should either name all three (new slab and basement) examples starting with ZoneCoupledGroundHT or revert this one back to BasementWithInsulation?

[mitchute]

@mjwitte Name change for this as well?

https://github.com/NREL/EnergyPlus/blob/1286412-Basement/testfiles/5ZoneAirCooledWithCoupledInGradeSlab.idf

[mjwitte]

Maybe, maybe not. It's part of the 5ZoneAirCooled series, so this one makes sense. Not sure we really need 3 example files for the slab feature, but I'm not sure we have a policy established regarding proliferation of example files.

[mitchute]

@mjwitte @Myoldmopar I went ahead and renamed the two slab files for consistency.

[Myoldmopar]

@mmAtTs Looks like the files got renamed, but the cmake rules didn't get updated based on these failures. I'll get it updated in testfiles/CMakeLists.txt.

[Myoldmopar]

@mmAtTs Does that commit (beef4b4) look like the correct filename changes?

[nrel-bot]

@mmAtTs @lgentile it has been 7 days since this pull request was last updated.

[Myoldmopar]

@mmAtTs I merged develop into this branch, and there were a few funny conflicts. I think I addressed them all, and the new file runs fine. I'm going to let CI have a pass at this, hopefully cleaning up the issues that aren't related to your work.

[Myoldmopar]

@mmAtTs The code looks good. Transition rules are in place and the affected idfs have been transitioned with the new slab object name. I ran a test file and found that the error file is still providing warnings about roof/ceiling upside-down. I'm going to remedy that and make one more check-in. I'm going to go back over the doc changes once more also. I think that once these things and the CI machines are done, if all is well, this should be ready to merge.

@mjwitte Did you have anything further you'd like to review before this gets merged (today/tomorrow)?

[mitchute]

@Myoldmopar I thought I had all of that fixed up, but thanks for catching it.

[Myoldmopar]

Alright, that last commit (beefe29) cleaned up those warnings, and the other two slab files have clean error files.

[Myoldmopar]

I forgot I had already reviewed the docs. I think this is merge-able as long as CI doesn't complain. And the Clang build just completed with just a slab file diff only. So far so good.

[mjwitte]

@Myoldmopar Found some errors in the idd by opening in IDFEditor. Was just about to commit. So, now what?

[Myoldmopar]

Commit and push it anyway, it will create a new branch up here by the same name, just as though you had started a new branch from scratch. I am curious if Github will connect this closed pull request to that branch or not. We'll see.

[mjwitte]

You sure? I could slightly rename the branch.

[Myoldmopar]

Renaming is fine, too. If you have the changes locally but haven't committed them, stash would be a nice way to do this also:

• "stash save" the changes you've made which will revert the branch back to the state it was in during the last pull
• Checkout develop locally, and do a Git Pull. Now your develop branch will have the basement stuff since it got merged.
• Create/check out a new branch called basement-idd-fix
• Do a "stash pop" to re-apply those changes you had previously stashed away. The IDD should be modified, and you'd be ready to commit and push.