New Variable Speed Heat Pump Water Heater Model #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fresh add-in and changes of VSHPWH
modify comment lines "EIR function" to "COP functions"
add WH pump power and energy rate output variables
Conflicts: src/EnergyPlus/WaterThermalTanks.cc testfiles/CMakeLists.txt
Conflicts: src/EnergyPlus/WaterThermalTanks.cc testfiles/CMakeLists.txt
Closed
|
I can take a look at it, but it might be next week before I can get around to it. |
|
@Myoldmopar @mbadams5 @lgentile it has been 7 days since this pull request was last updated. |
|
@Myoldmopar @mbadams5 @lgentile it has been 7 days since this pull request was last updated. |
| @@ -7034,8 +7168,17 @@ namespace WaterThermalTanks { | |||
| HPWHCondInletNodeLast = Node( HPWaterInletNode ).Temp; | |||
| HPWaterInletNodeTempSaved = Node( HPWaterInletNode ).Temp; | |||
| // This for loop is intended to iterate and converge on a condenser operating temperature so that the evaporator model correctly calculates performance. | |||
| // CHECK- embedded both the nonVS and the VS sim calls inside the for-loop, previously the VS wasn't in a for loop | |||
There was a problem hiding this comment.
This looks right to me. @Myoldmopar @shenb
|
@Myoldmopar @mbadams5 @lgentile it has been 7 days since this pull request was last updated. |
fix several bugs for the new feature of variable-speed air source heat pump water heater, after the merging conflict. remove several initialization issues.
|
@Myoldmopar @mbadams5 @lgentile it has been 7 days since this pull request was last updated. |
improve convergence and reduce number of warnings
merge develop except the water tank file
manually correct merging conflicts in waterthermaltanks.cc
Myoldmopar
added a commit
that referenced
this pull request
Apr 1, 2015
New Variable Speed Heat Pump Water Heater Model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes odd git gremlins in #4652.
@shenb @Myoldmopar
I need one of you three @shenb @nmerket @rraustad to look at WaterThermalTanks.cc and fix the merge conflicts in that file. There was a major refactoring done by @nmerket and I can't figure out the resolutions.
add the new feature development of variable-speed air-source heat pump water heater into the develop:
Files modified:
Add new object to Energy+.idd
New object: VariableSpeedCoils.cc, VariableSpeedCoils.hh
Parent object: WaterThermalTanks.cc, WaterThermalTanks.hh
New object declaration: DataHVACGlobals.cc, DataHVACGlobals.hh
Two new example files: VSHeatPumpWaterHeater.idf, VSWaterHeaterHeatPumpStratifiedTank.idf