Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4110 Correct Reverse Design Day testing so that results are identical #5707

Conversation

rraustad
Copy link
Contributor

@rraustad rraustad commented Jun 3, 2016

Pull request overview

Corrected Reverse DD failure for HeatPumpWaterToAirWithRHControl issue 4110. Expect no diff's in example files.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
    • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description

Review Checklist

This will not be exhaustively relevant to every PR.

  • Code style (parentheses padding, variable names)
  • Functional code review (it has to work!)
  • If defect, results of running current develop vs this branch should exhibit the fix
  • CI status: all green or justified
  • Performance: CI Linux results include performance check -- verify this
  • Unit Test(s)
  • C++ checks:
    • Argument types
    • If any virtual classes, ensure virtual destructor included, other things
  • IDD changes:
    • Verify naming conventions and styles, memos and notes and defaults
    • Open windows IDF Editor with modified IDD to check for errors
    • If transition, add rules to spreadsheet
    • If transition, add transition source
    • If transition, update idfs
  • If new idf included, locally check the err file and other outputs
  • Documentation changes in place
  • ExpandObjects changes??
  • If output changes, including tabular output structure, add to output rules file for interfaces

@rraustad
Copy link
Contributor Author

rraustad commented Jun 3, 2016

Issue #4110

Reverse DD test now passes for this file.

heatpumpwatertoairwithrhcontrol_new.csv
  vs
heatpumpwatertoairwithrhcontrol_switched_new.csv

All Records are Equal. 576 records compared

@rraustad rraustad changed the title Correct Reverse Design Day testing so that results are identical #4110 Correct Reverse Design Day testing so that results are identical Jun 3, 2016
@Myoldmopar Myoldmopar merged commit d22ca20 into develop Jun 16, 2016
@Myoldmopar Myoldmopar deleted the #4110-Reverse-DD-Testing-Failure-with-HeatPumpWaterToAirWithRHControl-(CR-#9339) branch June 16, 2016 14:02
@Myoldmopar Myoldmopar added the Defect Includes code to repair a defect in EnergyPlus label Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants