Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce full distribution of high temp radiant energy to surfaces and people #5830

Merged
merged 5 commits into from Aug 31, 2016

Conversation

RKStrand
Copy link
Contributor

@RKStrand RKStrand commented Aug 23, 2016

Pull request overview

This pull request includes the code fix, unit test, and minor documentation mod for a problem in the high temperature radiant heater code. In the code, a warning message was produced when the user did not assign all of the radiant energy emitted from the radiant heater to surfaces or people in a space. The code noted that the sum did not add up to unity and produced the warning but then simply continued to simulate things. This resulted in a loss of energy that could be up to 100% of the radiant energy. This was discovered by a user and a change was request. Now, the code will produce a severe warning and will also produce additional information telling the user what was processed and that this is not allowed. The documentation was also modified to clarify this as well. This fix applies to all high temperature radiant heater types and was logged as GitHub Issue #4324.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Review Checklist

This will not be exhaustively relevant to every PR.

  • Code style (parentheses padding, variable names)
  • Functional code review (it has to work!)
  • If defect, results of running current develop vs this branch should exhibit the fix
  • CI status: all green or justified
  • Performance: CI Linux results include performance check -- verify this
  • Unit Test(s)
  • C++ checks:
    • Argument types
    • If any virtual classes, ensure virtual destructor included, other things
  • n/a IDD changes:
  • n/a If new idf included, locally check the err file and other outputs
  • Documentation changes in place
  • Changed docs build successfully
  • n/a ExpandObjects changes?
  • n/a If output changes, including tabular output structure, add to output rules file for interfaces

Restarted this defect fix as something weird happened in GitHub and
push/pull/whatever.  This is most of the fixes minus the actual unit
test and review adjustments.
@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Aug 30, 2016
@mjwitte mjwitte added this to the EnergyPlus 8.6.0 milestone Aug 30, 2016
@mjwitte mjwitte merged commit 00ba29a into develop Aug 31, 2016
@mjwitte mjwitte deleted the 113837787-High-Temp-Radiant-Energy-Loss-2 branch August 31, 2016 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants