Enforce full distribution of high temp radiant energy to surfaces and people #5830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This pull request includes the code fix, unit test, and minor documentation mod for a problem in the high temperature radiant heater code. In the code, a warning message was produced when the user did not assign all of the radiant energy emitted from the radiant heater to surfaces or people in a space. The code noted that the sum did not add up to unity and produced the warning but then simply continued to simulate things. This resulted in a loss of energy that could be up to 100% of the radiant energy. This was discovered by a user and a change was request. Now, the code will produce a severe warning and will also produce additional information telling the user what was processed and that this is not allowed. The documentation was also modified to clarify this as well. This fix applies to all high temperature radiant heater types and was logged as GitHub Issue #4324.
Work Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
Review Checklist
This will not be exhaustively relevant to every PR.