Address issues due to Output:Variable regex

[mbadams5]

Pull request overview

This fixes the linux build issue since RE2 doesn't build with -fPIC apparently.

This also addresses the cppcheck warnings.

I also found and fixed a logic issue that was preventing the Output:Variables with regular expressions from outputting in the ESO file.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
  • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
  • Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
  • NewFeature: This pull request includes code to add a new feature to EnergyPlus
  • Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
  • DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

• Code style (parentheses padding, variable names)
• Functional code review (it has to work!)
• If defect, results of running current develop vs this branch should exhibit the fix
• CI status: all green or justified
• Performance: CI Linux results include performance check -- verify this
• Unit Test(s)
• C++ checks:
  • Argument types
  • If any virtual classes, ensure virtual destructor included, other things
• IDD changes:
  • Verify naming conventions and styles, memos and notes and defaults
  • Open windows IDF Editor with modified IDD to check for errors
  • If transition, add rules to spreadsheet
  • If transition, add transition source
  • If transition, update idfs
• If new idf included, locally check the err file and other outputs
• Documentation changes in place
• Changed docs build successfully
• ExpandObjects changes?
• If output changes, including tabular output structure, add to output rules file for interfaces

[mbadams5]

This corrects issues with #6017

[Myoldmopar]

Thanks for taking this on. I don't think the two failures have anything to do with this. Do you want to wait until Windows? Or can i merge this to start cleaning the dashboard back up?

[mbadams5]

I don't know what caused those regression failures since they are in the python scripts.

It is up to you whether to wait for windows or not. Looking at other branches that have been merged into develop or develop merged into them, it seems like the windows CIs are clean in develop. It looks like this only affects Linux.