Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output informational error messages #6068

Merged
merged 2 commits into from Mar 16, 2017
Merged

Output informational error messages #6068

merged 2 commits into from Mar 16, 2017

Conversation

mbadams5
Copy link
Contributor

@mbadams5 mbadams5 commented Mar 16, 2017

Pull request overview

Fixes #5318

This outputs informational messages during ShowMessage() function call
to sqlite. Now the whole error file is replicated in the sqlite Errors
table. This addresses #5318 since “Output:PreprocessorMessage”
informational messages call ShowMessage().

Since Warnings, Severe Errors, and Fatal Errors used 0, 1, 2 respectively in the sqlite Errors table, the informational messages now use -1 as the error code in the Errors table. I think makes the most sense since they are informational and it allows for easy queries to determine between informational and all the rest.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
    • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
    • Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
    • NewFeature: This pull request includes code to add a new feature to EnergyPlus
    • Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
    • DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

  • Code style (parentheses padding, variable names)
  • Functional code review (it has to work!)
  • If defect, results of running current develop vs this branch should exhibit the fix
  • CI status: all green or justified
  • Performance: CI Linux results include performance check -- verify this
  • Unit Test(s)
  • C++ checks:
    • Argument types
    • If any virtual classes, ensure virtual destructor included, other things
  • IDD changes:
    • Verify naming conventions and styles, memos and notes and defaults
    • Open windows IDF Editor with modified IDD to check for errors
    • If transition, add rules to spreadsheet
    • If transition, add transition source
    • If transition, update idfs
  • If new idf included, locally check the err file and other outputs
  • Documentation changes in place
  • Changed docs build successfully
  • ExpandObjects changes?
  • If output changes, including tabular output structure, add to output rules file for interfaces

Fixes #5318

This outputs informational messages during ShowMessage() function call
to sqlite. Now the whole error file is replicated in the sqlite Errors
table. This address #5318 since “Output:PreprocessorMessage”
informational messages call ShowMessage().
@mbadams5 mbadams5 added the Defect Includes code to repair a defect in EnergyPlus label Mar 16, 2017
@mbadams5 mbadams5 added this to the EnergyPlus 8.7.0 milestone Mar 16, 2017
@EnergyArchmage
Copy link
Contributor

EnergyArchmage commented Mar 16, 2017

I have reviewed this and all looks good to go.

Built branch locally, ran unit tests, using testfile _CTFTestsPart1.idf I inspected sqlite error tables using Sqliteman and preprocessor messages do show up as expected.

@EnergyArchmage EnergyArchmage merged commit 7dc8e05 into develop Mar 16, 2017
@EnergyArchmage EnergyArchmage deleted the fix_5318 branch March 16, 2017 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output:PreprocessorMessage messages at Information level are not in SQLite output
6 participants