New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ObjexxFCL 4.2 Upgrade #6212
Merged
Merged
ObjexxFCL 4.2 Upgrade #6212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeadParrot
added
the
Refactoring
Includes code changes that don't change the functionality of the program, just perform refactoring
label
Jul 16, 2017
…older GCC versions
… old gtest versions
@DeadParrot @lgentile it has been 14 days since this pull request was last updated. |
1 similar comment
@DeadParrot @lgentile it has been 14 days since this pull request was last updated. |
Agreed @DeadParrot, the errors thrown have nothing to do with these changes. I'm merging this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Refactoring
Includes code changes that don't change the functionality of the program, just perform refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates ObjexxFCL to version 4.2, which brings in a mix of minor refactoring, extended intrinsic functions, and a few minor fixes.
A handful of small changes were made in EnergyPlus source to migrate to revised ObjexxFCL function names.
No solution or performance impacts on EnergyPlus are expected.