Schedule manager refactor

[Myoldmopar]

Pull request overview

It's unclear at this point exactly what all this specific PR will include. There will be work to clean up the schedule manager, refactor it, add testing to it, and eventually add multi-year scheduling. This may only be an initial PR to clean up the code before making functional changes that could trigger small diffs.

Work Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:
  • Defect: This pull request repairs a github defect issue. The github issue should be referenced in the PR description
  • Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring
  • NewFeature: This pull request includes code to add a new feature to EnergyPlus
  • Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus
  • DoNoPublish: This pull request includes changes that shouldn't be included in the changelog

Review Checklist

This will not be exhaustively relevant to every PR.

• Functional code review (it has to work!)
• If defect, results of running current develop vs this branch should exhibit the fix
• CI status: all green or justified
• Performance: CI Linux results include performance check
• Unit Test(s)
• C++ checks:
  • Argument types
  • If any virtual classes, ensure virtual destructor included, other things
• IDD changes:
  • Verify naming conventions and styles, memos and notes and defaults
  • Open windows IDF Editor with modified IDD to check for errors
  • If transition, add to input rules file for interfaces
  • If transition, add transition source
  • If transition, update idfs
• If new idf included, locally check the err file and other outputs
• Required documentation updates?
• ExpandObjects changes?
• If output changes, including tabular output structure, add to output rules file for interfaces

[nrel-bot-2b]

@Myoldmopar @lgentile it has been 28 days since this pull request was last updated.

[Myoldmopar]

I'm expecting custom_check to fail again, with both a missing IDF in the cmake rules and also the PR is missing labels. But I improved both of those scripts to provide better links and info to the user, after I verify it properly warns with these changes, I'll get rid of those issues and custom_check will pass. Other, more serious test failures are still a little ways away from being resolved.

[nrel-bot]

@Myoldmopar @lgentile it has been 28 days since this pull request was last updated.

[nrel-bot-3]

@Myoldmopar @lgentile it has been 28 days since this pull request was last updated.

[nrel-bot-2c]

@Myoldmopar @lgentile it has been 28 days since this pull request was last updated.

[nrel-bot]

@Myoldmopar @lgentile it has been 28 days since this pull request was last updated.

[nrel-bot-2]

@Myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot-2b]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2]

@Myoldmopar it has been 12 days since this pull request was last updated.

[nrel-bot-2b]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2c]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2b]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2]

@Myoldmopar it has been 11 days since this pull request was last updated.

[nrel-bot-2c]

@Myoldmopar it has been 19 days since this pull request was last updated.

[nrel-bot-2b]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2c]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2b]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2b]

@Myoldmopar it has been 7 days since this pull request was last updated.

[nrel-bot-2c]

@Myoldmopar it has been 8 days since this pull request was last updated.

[nrel-bot-2b]

@Myoldmopar it has been 9 days since this pull request was last updated.

[nrel-bot-2]

@Myoldmopar it has been 13 days since this pull request was last updated.

[Myoldmopar]

I'm closing this temporarily. I have a new branch that I'll push shortly that addresses the biggest schedule manager fix -- the file reading. Then we can come back to this broader refactor later.