-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ideal loads air system ems override enthalpy update correction #8519
Changes from all commits
2a2d150
3a69126
fb2679a
6f78b76
b945ab1
1d500fa
cc37ad0
aa07520
818e87e
11e377e
8a9163e
d0edb77
da7af70
cb0d6dd
794a413
29c5866
d35704a
a416b98
14cf1d2
f4677e1
1e14220
b70fc91
784d91b
d8fa87e
7516db4
77c4439
69ecdf8
dbc3faf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2698,15 +2698,16 @@ void CalcPurchAirLoads(EnergyPlusData &state, | |
|
||
} // Cooling or heating required | ||
|
||
// EMS override point Purch air supply temp and humidty ratio ..... but only if unit is on, SupplyMassFlowRate>0.0 | ||
if (PurchAir(PurchAirNum).EMSOverrideSupplyTempOn) { | ||
PurchAir(PurchAirNum).SupplyTemp = PurchAir(PurchAirNum).EMSValueSupplyTemp; | ||
} | ||
if (PurchAir(PurchAirNum).EMSOverrideSupplyHumRatOn) { | ||
PurchAir(PurchAirNum).SupplyHumRat = PurchAir(PurchAirNum).EMSValueSupplyHumRat; | ||
} | ||
|
||
if (SupplyMassFlowRate > 0.0) { | ||
// EMS override point Purch air supply temp and humidty ratio ..... but only if unit is on, SupplyMassFlowRate>0.0 | ||
if (PurchAir(PurchAirNum).EMSOverrideSupplyTempOn) { | ||
PurchAir(PurchAirNum).SupplyTemp = PurchAir(PurchAirNum).EMSValueSupplyTemp; | ||
} | ||
if (PurchAir(PurchAirNum).EMSOverrideSupplyHumRatOn) { | ||
PurchAir(PurchAirNum).SupplyHumRat = PurchAir(PurchAirNum).EMSValueSupplyHumRat; | ||
} | ||
SupplyEnthalpy = PsyHFnTdbW(PurchAir(PurchAirNum).SupplyTemp, PurchAir(PurchAirNum).SupplyHumRat); | ||
|
||
// compute coil loads | ||
if ((PurchAir(PurchAirNum).SupplyHumRat == PurchAir(PurchAirNum).MixedAirHumRat) && | ||
(PurchAir(PurchAirNum).SupplyTemp == PurchAir(PurchAirNum).MixedAirTemp)) { | ||
|
@@ -2861,6 +2862,8 @@ void CalcPurchAirLoads(EnergyPlusData &state, | |
PurchAir(PurchAirNum).OALatOutput = 0.0; | ||
PurchAir(PurchAirNum).MixedAirTemp = Node(RecircNodeNum).Temp; | ||
PurchAir(PurchAirNum).MixedAirHumRat = Node(RecircNodeNum).HumRat; | ||
PurchAir(PurchAirNum).SupplyTemp = Node(InNodeNum).Temp; | ||
PurchAir(PurchAirNum).SupplyHumRat = Node(InNodeNum).HumRat; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This all looks reasonable but I am unsure of the difference between setting the supply node condition to the inlet versus the mixed node when the unit is off. @mjwitte ? And when EMS is setting the conditions, regardless if there is flow, shouldn't the supply condition reflect what EMS is writing to the node? I guess at 0 mass flow you can't have a delta T, w or H so this does make sense this way. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rraustad The supplytemp and supplyhumrat struct variables were added recently so that new output variables could be added. Since these are the conditions at the InNode, then they better have the same value. When flow is zero, the InNode conditions are set to match the zone node. That was done long ago, probably to make sure there aren't any funny noise values in the zone air balance calcs. |
||
} | ||
|
||
PurchAir(PurchAirNum).OutdoorAirMassFlowRate = OAMassFlowRate; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how setting the EMS conditions all the time to only when mass flow > 0 changes the answer. But then there are only 2 changes here so these changes certainly did something. Maybe it was the 2nd change that fixed this and this change just updates based on EMS only when there is flow. I guess that's OK (see other comment).