Ninja and warnings in unit tests #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
commented
Jun 18, 2021
Comment on lines
+31
to
+32
| elif 'Ninja' in generator_name: | ||
| return KnownBuildTypes.Makefile |
There was a problem hiding this comment.
Treat Ninja as Unix makefiles
Comment on lines
+36
to
+38
| def test_detect_ninja(self): | ||
| self.add_cache_file('CMAKE_GENERATOR:INTERNAL=Ninja') | ||
| self.assertEqual(KnownBuildTypes.Makefile, autodetect_build_dir_type(self.build_dir)) |
Comment on lines
+65
to
+76
| with open(os.path.join(temp_idf_dir, 'file1.idf'), 'w') as f: | ||
| f.write('hi') | ||
| with open(os.path.join(temp_idf_dir, 'file2.iQQ'), 'w') as f: | ||
| f.write('he') | ||
| with open(os.path.join(temp_idf_dir, 'file3.idf'), 'w') as f: | ||
| f.write('ha') | ||
| with open(os.path.join(temp_idf_dir, 'file4.imf'), 'w') as f: | ||
| f.write('ha') # macro | ||
| with open(os.path.join(temp_idf_dir, '_ExternalInterface-actuator.idf'), 'w') as f: | ||
| f.write('ha') # ext interface as FMU | ||
| with open(os.path.join(temp_idf_dir, 'HVAC3ZoneGeometry.imf'), 'w') as f: | ||
| f.write('ha') # macro resource file |
There was a problem hiding this comment.
Avoid warning when running unittests ResourceWarning: unclosed file <_io.TextIOWrapper
There was a problem hiding this comment.
I guess could've appended .close() on each of the lines, but this is good.
Myoldmopar
approved these changes
Jul 30, 2021
Comment on lines
+31
to
+32
| elif 'Ninja' in generator_name: | ||
| return KnownBuildTypes.Makefile |
Comment on lines
+36
to
+38
| def test_detect_ninja(self): | ||
| self.add_cache_file('CMAKE_GENERATOR:INTERNAL=Ninja') | ||
| self.assertEqual(KnownBuildTypes.Makefile, autodetect_build_dir_type(self.build_dir)) |
Comment on lines
+65
to
+76
| with open(os.path.join(temp_idf_dir, 'file1.idf'), 'w') as f: | ||
| f.write('hi') | ||
| with open(os.path.join(temp_idf_dir, 'file2.iQQ'), 'w') as f: | ||
| f.write('he') | ||
| with open(os.path.join(temp_idf_dir, 'file3.idf'), 'w') as f: | ||
| f.write('ha') | ||
| with open(os.path.join(temp_idf_dir, 'file4.imf'), 'w') as f: | ||
| f.write('ha') # macro | ||
| with open(os.path.join(temp_idf_dir, '_ExternalInterface-actuator.idf'), 'w') as f: | ||
| f.write('ha') # ext interface as FMU | ||
| with open(os.path.join(temp_idf_dir, 'HVAC3ZoneGeometry.imf'), 'w') as f: | ||
| f.write('ha') # macro resource file |
There was a problem hiding this comment.
I guess could've appended .close() on each of the lines, but this is good.
|
Merging this little thing in, sorry it took so long to context switch over to this, now quick I gotta go back to other work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Myoldmopar
FOr some reason, these changes work in the unit test, but the GUI doesn't seem to register them. (I installed it by going to the root of the repo and typing
pip install -e .[dev,test])Edit: Nevermind. I was selecting the build folder then clicking OK, I realize now that I needed to actually double click the build folder to enter it before clicking ok. The changes are still needed though.