-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pvsamv1 properties and setters for interdependent parameters #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another thought I had was that it would be good to move a lot of the functionality in pv_design_utils.py
and pv_inverter
.py` into PySAM where it'll probably get a broader user base. Not something we can do with the current project, but I'll ask if it's appropriate for SAM core
@Matthew-Boyd I added an assert for the PV system capacity in here: a6275cc This now causes the |
@Matthew-Boyd Looking at the latest change, I think it went in the wrong direction. The DetailedPVPlant needs to be able to use a system capacity. Can you tell me what the input dictionary format for DetailedPVPlant should be? Where does the system_capacity input go? IIRC, the input dictionary format for the simple PVPlant is different since there's no "tech_config" required. |
@dguittet The input dictionary format for the I will add another test to ensure the |
Conflicts: hybrid/layout/pv_design_utils.py
This includes properties and setters for all interdependent parameters, including: