Added Electrolyzer Physics Tests #275

elenya-grant · 2024-02-27T00:00:51Z

Added GreenHEART Electrolyzer Physics Tests

Added on and off-grid electrolyzer physics tests

Related issue

Impacted areas of the software

Files Updated:

greenheart/tools/eco/electrolysis.py
tests/greenheart/test_hydrogen/input_files/plant/greenheart_config.yaml

Files Added:

tests/greenheart/test_hydrogen/test_electrolyzer_physics.py
tests/greenheart/test_hydrogen/input_files/plant/GS_greenheart_config.yaml
tests/greenheart/test_hydrogen/input_files/plant/GS_gridonly_power_signal.csv
tests/greenheart/test_hydrogen/input_files/plant/GS_offgrid_power_signal.csv

Additional supporting information

Part of land-based and offshore green steel code coordination and sync-up tasks. Test values are based on grid-only and off-grid land-based electrolyzer results.

Test results, if applicable

…s. Merge remote-tracking branch 'hopp_main/greensteel-eco-sync' into greensteel-eco-sync

jaredthomas68

Looks pretty good. Thank you Elenya! I left a few comments, but they should all be pretty easy to address.

greenheart/tools/eco/electrolysis.py

tests/greenheart/test_hydrogen/input_files/plant/GS_greenheart_config.yaml

tests/greenheart/test_hydrogen/test_electrolyzer_physics.py

greenheart/tools/eco/electrolysis.py

jaredthomas68 · 2024-02-27T20:27:40Z

Also, please make sure all checks are passing before we merge this.

…in/greensteel-eco-sync' into greensteel-eco-sync

…e and updated relevant files and tests

…_config.yaml

… physics tests

…reensteel-eco-sync' into greensteel-eco-sync

jaredthomas68

I think this will do.

greenheart/tools/plant_sizing_estimation.py

greenheart/tools/eco/electrolysis.py

tests/greenheart/test_hydrogen/input_files/plant/GS_greenheart_config.yaml

…input power

jaredthomas68

Looks close. I left a few comments, mostly implementation/syntax/comment related.

greenheart/tools/eco/electrolysis.py

greenheart/tools/plant_sizing_estimation.py

tests/greenheart/test_hydrogen/input_files/plant/GS_gridonly_power_signal.csv

tests/greenheart/test_hydrogen/input_files/plant/greenheart_config.yaml

tests/greenheart/test_hydrogen/test_electrolyzer_physics.py

…ming conventions, updated test inputs

…ommit

…ls to electrical_generation_timeseries as calls to power_to_electrolyzer_kw

… code

…d updated keys in electrolyzer_physics_results[H2_Results]

jaredthomas68

Thanks for your good work on this Elenya, just a few comments.

greenheart/simulation/technologies/hydrogen/electrolysis/PEM_H2_LT_electrolyzer_Clusters.py

greenheart/tools/eco/electrolysis.py

…put to run_electrolyzer_physics

…put, the hydrogen_dmd input of greenheart_config has to be None

jaredthomas68

I think this will do. Thank you @elenya-grant!

elenya-grant added 8 commits February 23, 2024 09:34

added electrolyzer test draft and updating electrolysis.py

072a071

changed eco_config to greenheart_config

ca1583c

completed electrolyzer physics tests, all passing, need to clean up

9c50181

updated electrolysis.py for sync-up cases

300976a

updated greenheart_config.yaml to include new electrolyzer inputs

77c8e16

removed unused imports and cleaned up

2c92dc1

Merge upstream changes into local changes, should have no merge issue…

f3b1829

…s. Merge remote-tracking branch 'hopp_main/greensteel-eco-sync' into greensteel-eco-sync

added power signals for electrolyzer tests

fa80488

elenya-grant requested a review from jaredthomas68 February 27, 2024 00:00

jaredthomas68 requested changes Feb 27, 2024

View reviewed changes

elenya-grant added 15 commits February 27, 2024 15:18

Update with most recent commits.Merge remote-tracking branch 'hopp_ma…

a63e86e

…in/greensteel-eco-sync' into greensteel-eco-sync

updated lcoh test values to reflect updated electrolyzer inputs

b56c689

cleaned up electrolyzer physics test file a bit

8bd771a

just removed whitespace in GS_greenheart_config.yaml

5bc06a0

removed unused inputs in config files, changed some input nomenclatur…

dc823a0

…e and updated relevant files and tests

updated LCOH values because changed EOL efficiency loss in greenheart…

859fa9b

…_config.yaml

added electrolyzer sizing functions and tests

77342c0

updated electrolyzer sizing functions, config files, and electrolyzer…

69cd8d1

… physics tests

update to include end-uses. Merge remote-tracking branch 'hopp_main/g…

1913997

…reensteel-eco-sync' into greensteel-eco-sync

added plant_sizing function and file

9cac874

added quick tests for electrolyzer resizing based on steel demand

9325923

removed resize bool in testing config file used for other tests

5edf44f

removed debug code

b8504e8

removed commented out stuff at end of file

471951e

renamed hybrid_cf_est to hybrid_electricity_estimated_cf

e429b01

jaredthomas68 reviewed Feb 28, 2024

View reviewed changes

greenheart/tools/plant_sizing_estimation.py Outdated Show resolved Hide resolved

kbrunik reviewed Feb 29, 2024

View reviewed changes

elenya-grant added 2 commits February 29, 2024 11:25

removed GS_greenheart_config.yaml

08fc82a

removed grid_input_signal from input and toggle in electrolysis.py

e88c081

elenya-grant added 4 commits February 29, 2024 11:27

changed electrolyzer physics tests to new format

bfadc5d

updated capacity factor to electrolyzer results rather than based on …

53b8157

…input power

accepted incoming changes

2414a12

updated input files organization for component sizing and relevant files

bba7fe4

jaredthomas68 self-requested a review March 12, 2024 19:45

Merge branch 'greensteel-eco-sync' into greensteel-eco-sync

28cef00

jaredthomas68 requested changes Mar 20, 2024

View reviewed changes

elenya-grant added 10 commits March 21, 2024 13:37

removed unused inputs for PEM_H2_LT_Electrolyzer_Clusters, updated na…

7051323

…ming conventions, updated test inputs

updated electrolyzer input variables to reflect changes in previous c…

5406cb1

…ommit

added note of where test values came from to electrolyzer test file

49b34a1

merged greenheart_config.yaml

7016516

still just merged greenheart_config.yaml?

0f010b9

changed electrolyzer_physics_results keys and outputs and updated cal…

2ee36f4

…ls to electrical_generation_timeseries as calls to power_to_electrolyzer_kw

changed H2_results in run_h2_PEM.py, need to delete commented-out old…

e2aaa6e

… code

updated calls to electrolyzer_physics_results for the updated keys an…

97f0d40

…d updated keys in electrolyzer_physics_results[H2_Results]

fixing divergent branches

b1aef60

fixed bug in desal power output caused from a previous commit

c7dcb09

jaredthomas68 requested changes Mar 22, 2024

View reviewed changes

greenheart/simulation/technologies/hydrogen/electrolysis/PEM_H2_LT_electrolyzer_Clusters.py Outdated Show resolved Hide resolved

greenheart/tools/eco/electrolysis.py Show resolved Hide resolved

greenheart/tools/eco/electrolysis.py Outdated Show resolved Hide resolved

removed old comments

55aef5c

elenya-grant mentioned this pull request Mar 26, 2024

Expand grid-connected electrolyzer options #294

Open

elenya-grant added 3 commits March 26, 2024 13:26

merged in greensteel-eco-sync and fixed merge conflicts

00bb555

moved project_lifetime to test input dictionary rather than direct in…

9e78e07

…put to run_electrolyzer_physics

workaround for grid-connected electrolyzer runs, to run with power in…

5f9aa61

…put, the hydrogen_dmd input of greenheart_config has to be None

jaredthomas68 self-requested a review March 28, 2024 18:04

jaredthomas68 approved these changes Mar 28, 2024

View reviewed changes

jaredthomas68 merged commit 6d93aea into NREL:greensteel-eco-sync Mar 28, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Electrolyzer Physics Tests #275

Added Electrolyzer Physics Tests #275

elenya-grant commented Feb 27, 2024

jaredthomas68 left a comment

jaredthomas68 commented Feb 27, 2024

jaredthomas68 left a comment

jaredthomas68 left a comment

jaredthomas68 left a comment

jaredthomas68 left a comment

Added Electrolyzer Physics Tests #275

Added Electrolyzer Physics Tests #275

Conversation

elenya-grant commented Feb 27, 2024

Added GreenHEART Electrolyzer Physics Tests

Related issue

Impacted areas of the software

Additional supporting information

Test results, if applicable

jaredthomas68 left a comment

Choose a reason for hiding this comment

jaredthomas68 commented Feb 27, 2024

jaredthomas68 left a comment

Choose a reason for hiding this comment

jaredthomas68 left a comment

Choose a reason for hiding this comment

jaredthomas68 left a comment

Choose a reason for hiding this comment

jaredthomas68 left a comment

Choose a reason for hiding this comment