Reference design examples #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added email for API calls to be set in .env file and removed self.email from resource.py * changed EMAIL to NREL_API_EMAIL * added space after comma seperator
jaredthomas68
approved these changes
Mar 29, 2024
| "2064": 84.74628619479452 | ||
|
|
||
| # Additional parameters passed to ProFAST | ||
| financial_assumptions: |
There was a problem hiding this comment.
These should probably all be in the finance parameters, and I think they are duplicative as well. We need to discuss this.
| output_level=7, | ||
| ) | ||
|
|
||
| config.hopp_config["technologies"]["wind"]["fin_model"]["system_costs"]["om_fixed"][ |
There was a problem hiding this comment.
This seems like stuff that we should add to the software, not do in the example. I think it makes sense to have the cost_info override the default fin config for now, but we should do it in the init, not the run script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating reference design for green steel and ammonia plants
Adding reference design examples for five locations around the United States. Two onshore examples and three offshore wind examples. Locations and outputs are as follows
Related issue
Impacted areas of the software
Additional supporting information
Test results, if applicable