Gb/nrwal config #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grantbuster
force-pushed
the
gb/nrwal_config
branch
from
1653641
to
2b43c9c
Compare
…, and equations containing variables.yaml files
grantbuster
force-pushed
the
gb/nrwal_config
branch
from
c6de764
to
1023b22
Compare
grantbuster
force-pushed
the
gb/nrwal_config
branch
from
ad9796a
to
774c1a8
Compare
that global variables set in config get parsed in as Equation objects
|
Hey @JakeNunemaker i finished the features we discussed. You can now use parenthetical statements in all math expressions and NRWAL object retrievals. I've outlawed Equations and config objects keyed by numbers so that there's no confusion with a year-dependent equation and just a constant number in an equation (think scaling equations by 1000 but the 1000 being confused with a year). Finally, you can now interpolate/extrapolate/find_nearest on both power equations (_10MW) and year equations (_YYYY). Includes tests for everything. Ready for review / merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First take at the NRWAL config. Use examples here