Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc hpxml.rb cleanup #1713

Merged
merged 5 commits into from
May 15, 2024
Merged

Misc hpxml.rb cleanup #1713

merged 5 commits into from
May 15, 2024

Conversation

shorowit
Copy link
Contributor

Pull Request Description

Renames attributes to be more consistent w/ HPXML schema. Minor refactor. No diffs expected.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this May 15, 2024
@shorowit shorowit merged commit 1206d19 into zone_design_loads May 15, 2024
@shorowit shorowit deleted the hpxml_subsurface_attrs branch May 15, 2024 22:24
@joseph-robertson joseph-robertson mentioned this pull request May 16, 2024
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shorowit shorowit

Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@shorowit