Replaces Unmet Load outputs with Unmet Hours #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o unmet_hours # Conflicts: # HPXMLtoOpenStudio/measure.xml
8 tasks
|
@yzhou601 Can you investigate the sum of component loads vs total reported load for the base-hvac-undersized.xml file? (Might also move ducts into living space.) 🕵️♀️ |
yzhou601
approved these changes
Sep 9, 2021
There was a problem hiding this comment.
Changes look good to me. I've run tests with duct placing to the living space. The results are:
Master branch shows consistent loads between undersize and base test files, unmet hour branch shows reduction in load reporting caused by unmet loads. The energy increase on unmet hour branch is expected.
I have run 3 undersized test files on unmet_hours branch, they all show consistency between total loads and individual load sums. I have kind of persuaded myself, this can be caused by zone air temperature was overall kept in a reasonable range, so energy is still balanced.
…o unmet_hours # Conflicts: # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results.csv
…into unmet_hours
nmerket
pushed a commit
that referenced
this pull request
Dec 29, 2023
7b2f57b Merge pull request #846 from NREL/unmet_hours 05b0ebe Merge branch 'unmet_hours' of https://github.com/NREL/OpenStudio-HPXML into unmet_hours 0e85797 Clean up changelog [ci skip] 0745a43 Latest results. f4ca649 Fix tests. 47de347 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unmet_hours c598bc8 Add "Delivered" to load outputs; update documentation and changelog. 00c2a56 Merge pull request #853 from NREL/radiant_barrier_fix 5d43e8d Latest results. f7ea643 Reduce ceiling insulation in test file to increase effect of radiant barrier. bc509ec Bugfix for radiant barrier properties being overridden in some situations. 2c316f7 Latest results. 5349f5e Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into unmet_hours 0c0f989 Merge pull request #851 from NREL/hvac_sizing_bugfix ec78517 Latest results. d54e083 Fix for ductless systems. 3de83b1 Fixes duct design load calculations for HPXML files with multiple ducted HVAC systems. 9dace43 Merge pull request #850 from NREL/fix_compare_py 3b4a6c3 Latest results. 47bf66d Revert to original. 3033e8c Merge branch 'fix_compare_py' of https://github.com/NREL/OpenStudio-HPXML into fix_compare_py 06aa605 Fix division by zero error? 467825c Latest results. d243525 Attempt to reproduce the issue. 1a54a1a Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into master 0407b87 Latest results. b7eb15f Update docs. [ci skip] 5fe7f6e Oops. 7b34d64 Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into master 3786764 Merge branch 'reduce_timeseries' of https://github.com/NREL/OpenStudio-HPXML into master git-subtree-dir: hpxml-measures git-subtree-split: 7b2f57b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #840.
Checklist
Not all may apply:
EPvalidator.xml has been updatedopenstudio tasks.rb update_measureshas been run