OSA Schema #583
Merged
OSA Schema #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nllong
commented
Jul 14, 2020
nllong
commented
- Add an OSA JSON schema. The location is server/app/lib/analysis_library/schema/osa.json but I am thinking we should place in /server/schemas.
- Should probably make a datapoint.json schema as well.
nllong
commented
Jul 14, 2020
| @@ -123,4 +123,6 @@ group :development, :test do | |||
| gem 'factory_bot_rails', '4.11.1' # 5.0.2 require ruby 2.3 | |||
| gem 'mongoid-rspec' | |||
| gem 'rspec-html-matchers', '0.8.1' | |||
|
|
|||
| gem 'json-schema', '2.8.0' | |||
There was a problem hiding this comment.
Only needed for development.
nllong
commented
Jul 14, 2020
nllong
commented
Jul 14, 2020
nllong
commented
Jul 14, 2020
nllong
commented
Jul 14, 2020
brianlball
reviewed
Jul 17, 2020
brianlball
reviewed
Jul 17, 2020
brianlball
reviewed
Jul 17, 2020
| "default": 2, | ||
| "minimum": 1 | ||
| }, | ||
| "popSize": { |
There was a problem hiding this comment.
is popsize and popSize different?
There was a problem hiding this comment.
they world be since json is case sensitive.
brianlball
reviewed
Jul 17, 2020
brianlball
reviewed
Jul 17, 2020
| "default": 2, | ||
| "minimum": 0 | ||
| }, | ||
| "ppower": { |
brianlball
reviewed
Jul 17, 2020
| "type": "number", | ||
| "default": 5 | ||
| }, | ||
| "xoverdistidx": { |
There was a problem hiding this comment.
I think we leave these for now even if they aren't used.
brianlball
reviewed
Jul 17, 2020
| "type": "number", | ||
| "default": 2 | ||
| }, | ||
| "toursize": { |
brianlball
reviewed
Jul 17, 2020
| "minkowski", "maximum", "euclidean", "binary", "manhattan" | ||
| ] | ||
| }, | ||
| "normtype": { |
brianlball
reviewed
Jul 17, 2020
| "type": "number", | ||
| "default": 10 | ||
| }, | ||
| "mudistidx": { |
brianlball
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.