Skip to content

Commit

Permalink
Change default "Heat Recovery Bypass Control Type"
Browse files Browse the repository at this point in the history
In ControllerOutdoorAir change the default value for
field "Heat Recovery Bypass Control Type" from
"BypassWhenOAFlowGreaterThanMinimum" to
"BypassWhenWithinEconomizerLimits".

The old value was majorly messing up oa rates even when there is no heat
recovery device.  This corrects unmet hours in CBECC lab model, which is
approximatly system 7, but with exahaust fans and 100% oa.  Many other
models could be inflicted with this problem, which ultimately is an
EnergyPlus bug documented here:
NREL/EnergyPlus#4568.  The scope of this issue
in OpenStudio models is unclear but is being investigated with the
EnergyPlus issue 4568.  It may or may not be isolated to 100% OA and/or
exhaust fans.

[#81583558]
  • Loading branch information
kbenne committed Oct 30, 2014
1 parent 7f4005f commit 735188a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion openstudiocore/src/model/ControllerOutdoorAir.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -677,7 +677,7 @@ ControllerOutdoorAir::ControllerOutdoorAir(const Model& model)
setString(OS_Controller_OutdoorAirFields::HumidistatControlZoneName,"");
setString(OS_Controller_OutdoorAirFields::HighHumidityOutdoorAirFlowRatio,"");
setString(OS_Controller_OutdoorAirFields::ControlHighIndoorHumidityBasedonOutdoorHumidityRatio,"");
setHeatRecoveryBypassControlType("BypassWhenOAFlowGreaterThanMinimum");
setHeatRecoveryBypassControlType("BypassWhenWithinEconomizerLimits");

ControllerMechanicalVentilation controllerMechanicalVentilation(model);
setControllerMechanicalVentilation(controllerMechanicalVentilation);
Expand Down

4 comments on commit 735188a

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

81583558-SetpointManagerWarmestTemperatureFlow (kbenne) - x86_64-MacOS-10.9-clang: OK (2126 of 2146 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

81583558-SetpointManagerWarmestTemperatureFlow (kbenne) - x86_64-Linux-Ubuntu-14.04-clang-3.5: OK (2126 of 2146 tests passed)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

81583558-SetpointManagerWarmestTemperatureFlow (kbenne) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: OK (0 of 0 tests passed)

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

81583558-SetpointManagerWarmestTemperatureFlow (kbenne) - i386-Windows-7-VisualStudio-12: Tests Failed

Build Badge Test Badge

Please sign in to comment.