Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zones with FanZoneExhaust require thermostat schedules #1706

Closed
MatthewSteen opened this issue Jun 29, 2015 · 11 comments · Fixed by #1826
Closed

Zones with FanZoneExhaust require thermostat schedules #1706

MatthewSteen opened this issue Jun 29, 2015 · 11 comments · Fixed by #1826
Assignees

Comments

@MatthewSteen
Copy link
Member

For zones with only a FanZoneExaust OS requires thermostat schedules to run successfully whereas EP does not. I think the problem is that when the cooling and heating setpoints are deleted from a zone with only an exhaust fan the ThermostatSchedule:DualSetpoint objects are being deleted but the ZoneControl:Thermostat object that reference the setpoint schedules is not until the FanZoneExhaust is deleted.

@kbenne suggested this may be a grid view bug where the old On/Off tstat switch functionality is not completely implemented. This is a low frequency bug that only occurs with FanZoneExhaust zones since the other ZoneHVAC objects provide conditioning and need tstats to run.

FYI @evanweaver

@DavidGoldwasser
Copy link
Collaborator

Thanks @MatthewSteen nice catch

@MatthewSteen
Copy link
Member Author

This may also affect CBECC-Com users and require them to assign tstat schedules.

@DavidGoldwasser
Copy link
Collaborator

@kbenne please assign to 1.9.0 milestone if you think it is needed for that release.

kbenne added a commit that referenced this issue Sep 1, 2015
OS -> E+ translator would happily translate a partial
ThermostatSetpointDualSetpoint even if one or both schedules are
missing. This causes an EnergyPlus simulation failure. This change makes
it so that a dual setpoint thermostat will only be translated if it has
schedules attached.

This change has become more important with the introduction of
ThermalZone grid view, where there is no longer an explicit on/off
button that effectively allows user control over add/remove
ThermostatSetpointDualSetpoint. A different solution to this problem is
to reprogram grid view to remove the thermostat when the last schedule
is removed, but I think this solution will handle more use cases. It
does come at the expense of perhaps a tiny bit of "magic" but I think it
is acceptable, and will certainly keep more simulations running cleanly.

close #1706
@kbenne
Copy link
Contributor

kbenne commented Sep 1, 2015

@MatthewSteen I'd like to follow my favorite new way of verifying bug fixes and send you an installer package to test. What do you think, is this something you could do for me?

@MatthewSteen
Copy link
Member Author

Sure, fire away.

@kbenne
Copy link
Contributor

kbenne commented Sep 1, 2015

also @MatthewSteen and @evanweaver read my commit log for the details, but basically yes this problem has been agitated by grid view, but my solution is actually in the translator. I don't think the grid view behavior is all that bad.

@evanweaver for what it is worth the alternative solution in grid view would be to remove the thermostat on the last schedule reset here.

@MatthewSteen
Copy link
Member Author

@kbenne I'm actually at your office today if you want to put it on a 5.25" 💾

@kbenne
Copy link
Contributor

kbenne commented Sep 1, 2015

hehe. What and snail mail it?!

@evanweaver
Copy link
Contributor

Ha, our technical prowess has been recognized.

@kbenne
Copy link
Contributor

kbenne commented Sep 1, 2015

@MatthewSteen I emailed a link to you.

@MatthewSteen
Copy link
Member Author

@kbenne received, tested against 1.8.2, and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants