New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zones with FanZoneExhaust require thermostat schedules #1706
Comments
Thanks @MatthewSteen nice catch |
This may also affect CBECC-Com users and require them to assign tstat schedules. |
@kbenne please assign to 1.9.0 milestone if you think it is needed for that release. |
OS -> E+ translator would happily translate a partial ThermostatSetpointDualSetpoint even if one or both schedules are missing. This causes an EnergyPlus simulation failure. This change makes it so that a dual setpoint thermostat will only be translated if it has schedules attached. This change has become more important with the introduction of ThermalZone grid view, where there is no longer an explicit on/off button that effectively allows user control over add/remove ThermostatSetpointDualSetpoint. A different solution to this problem is to reprogram grid view to remove the thermostat when the last schedule is removed, but I think this solution will handle more use cases. It does come at the expense of perhaps a tiny bit of "magic" but I think it is acceptable, and will certainly keep more simulations running cleanly. close #1706
@MatthewSteen I'd like to follow my favorite new way of verifying bug fixes and send you an installer package to test. What do you think, is this something you could do for me? |
Sure, fire away. |
also @MatthewSteen and @evanweaver read my commit log for the details, but basically yes this problem has been agitated by grid view, but my solution is actually in the translator. I don't think the grid view behavior is all that bad. @evanweaver for what it is worth the alternative solution in grid view would be to remove the thermostat on the last schedule reset here. |
@kbenne I'm actually at your office today if you want to put it on a 5.25" 💾 |
hehe. What and snail mail it?! |
Ha, our technical prowess has been recognized. |
@MatthewSteen I emailed a link to you. |
@kbenne received, tested against 1.8.2, and it works. |
For zones with only a FanZoneExaust OS requires thermostat schedules to run successfully whereas EP does not. I think the problem is that when the cooling and heating setpoints are deleted from a zone with only an exhaust fan the ThermostatSchedule:DualSetpoint objects are being deleted but the ZoneControl:Thermostat object that reference the setpoint schedules is not until the FanZoneExhaust is deleted.
@kbenne suggested this may be a grid view bug where the old On/Off tstat switch functionality is not completely implemented. This is a low frequency bug that only occurs with FanZoneExhaust zones since the other ZoneHVAC objects provide conditioning and need tstats to run.
FYI @evanweaver
The text was updated successfully, but these errors were encountered: