Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gbXML translation does not roundtrip unless Facility object present #3314

Closed
macumber opened this issue Oct 16, 2018 · 0 comments · Fixed by #4000
Closed

gbXML translation does not roundtrip unless Facility object present #3314

macumber opened this issue Oct 16, 2018 · 0 comments · Fixed by #4000

Comments

@macumber
Copy link
Contributor

The following code will fail unless the model has a Facility object present

  ForwardTranslator forwardTranslator;
  bool test = forwardTranslator.modelToGbXML(model, p);

  EXPECT_TRUE(test);

  // Read the XML back in and check the surface
  ReverseTranslator reverseTranslator;
  boost::optional<Model> model2 = reverseTranslator.loadModel(p);

  ASSERT_TRUE(model2);

Also, Spaces will not be translated without a Building.

jmarrec added a commit that referenced this issue Jun 18, 2020
jmarrec added a commit that referenced this issue Jun 18, 2020
tijcolem added a commit that referenced this issue Jun 18, 2020
Fix #3314 - GBXML translate spaces etc even if Facility and/or Building aren't instantiated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant