Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gbXML forward translator modelToGbXML to string versus saving the file to a path #4125

Closed
arif-hanif opened this issue Oct 21, 2020 · 0 comments · Fixed by #4136
Closed

gbXML forward translator modelToGbXML to string versus saving the file to a path #4125

arif-hanif opened this issue Oct 21, 2020 · 0 comments · Fixed by #4136
Assignees
@jmarrec
Labels
component - gbXML Enhancement Request
Projects
OpenStudio
Milestone
OpenStudio SDK 3.2.0

Comments

@arif-hanif
Copy link
Contributor

Allow users to obtain the string of the forward translation of osm to gbxml vs saving to a path.
@arif-hanif arif-hanif added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Oct 21, 2020
@tijcolem tijcolem added this to the OpenStudio SDK 3.2.0 milestone Oct 30, 2020
@tijcolem tijcolem added component - Model component - gbXML and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed component - Model labels Oct 30, 2020
@tijcolem tijcolem added this to Current Backlog in OpenStudio Oct 30, 2020
@jmarrec jmarrec mentioned this issue Nov 2, 2020
Closed
jmarrec added a commit that referenced this issue Nov 2, 2020
@jmarrec
Fix #4125 - add modelToGbXMLString
a52622c
jmarrec added a commit that referenced this issue Nov 2, 2020
@jmarrec
Add a test for #4135, which also tests modelToGbXMLString (#4125)
9df17c7
@jmarrec jmarrec mentioned this issue Nov 2, 2020
Merged
20 tasks
OpenStudio automation moved this from Current Backlog to Done Nov 3, 2020
tijcolem added a commit that referenced this issue Nov 3, 2020
@tijcolem
Merge pull request #4136 from NREL/4125_4135_GbXML_ForwardTranslator
d7cf7c8 
Fix #4125, Fix #4135 - GbXML ForwardTranslator: clear map&set, and add a modelToGbXMLString method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmarrec jmarrec

Labels
component - gbXML Enhancement Request
Projects
No open projects
OpenStudio
  
Done
Milestone
OpenStudio SDK 3.2.0
3 participants
@jmarrec @tijcolem @arif-hanif