Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap the E+ Table:Lookup, Table:IndependentVariableList, and Table:IndependentVariable objects. #4647

Closed
tijcolem opened this issue Aug 15, 2022 · 3 comments · Fixed by #4652

Comments

@tijcolem
Copy link
Collaborator

Enhancement Request

Coming from @asparke2 from an email request.

Wrap the E+ Table:Lookup, Table:IndependentVariableList, and Table:IndependentVariable objects. OS has the previous E+ incarnation of the LookupTable objects wrapped, but I believe those were replaced with these new ones. This new format is what Eric Bonnema used to represent the Carrier HP performance.

@tijcolem tijcolem added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Aug 15, 2022
@joseph-robertson
Copy link
Collaborator

Looks like these three objects would replace Table:MultiVariableLookup (and Table:MultiVariableLookupPoint). Should we:

  • add the new objects and deprecate the old objects, or
  • add the new objects and not deprecate the old objects, or
  • add the new objects and remove the old objects

?

We'd need VT if we remove the old objects.

@asparke2
Copy link
Member

It appears that the old objects no longer exist in EnergyPlus and have been replaced by the newer ones. If this is true, my vote is to deprecate the old objects, add the new ones, and have a version translator from old to new.

@tijcolem tijcolem added component - Model and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Aug 19, 2022
@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.5.0 milestone Aug 19, 2022
@joseph-robertson joseph-robertson added this to In progress in OpenStudio Aug 19, 2022
@jmarrec
Copy link
Collaborator

jmarrec commented Aug 22, 2022

For context, 9.2.0 made the change from TableMultiVariableLookup to the three new objects.

At the time it was decided to keep the current model API (cf #3651) and handle everything in forward translation, which is what #3653 did.

FWIW, I find the old single-object implementation clearer.

OpenStudio automation moved this from In progress to Done Sep 8, 2022
jmarrec added a commit that referenced this issue Sep 8, 2022
Addresses #4647, wrap the E+ Table:Lookup, Table:IndependentVariableList, and Table:IndependentVariable objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
OpenStudio
  
Done
4 participants