Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi speed DX coil stage mapping does not clone properly with airloop #4663

Closed
mleachNREL opened this issue Aug 29, 2022 · 2 comments · Fixed by #4683
Closed

multi speed DX coil stage mapping does not clone properly with airloop #4663

mleachNREL opened this issue Aug 29, 2022 · 2 comments · Fixed by #4683

Comments

@mleachNREL
Copy link
Contributor

mleachNREL commented Aug 29, 2022

Issue overview

Current Behavior

When I clone an airloop with multi speed DX coils using the OS API, the coils themselves are cloned properly, as well as their corresponding stages (dx multi speed stage data objects). But the stage assignments do not map over (the stage fields in the coil object are blank)

Expected Behavior

It should work.

Steps to Reproduce

Let me know what details you need to investigate. I don't think it makes sense to attach a model will blank fields as evidence. It wouldn't really show anything...

Possible Solution

Details

Environment

Some additional details about your environment for this issue (if relevant):

  • Version of OpenStudio (if using an intermediate build, include SHA): 3.4.0
@mleachNREL mleachNREL added the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Aug 29, 2022
@tijcolem tijcolem added component - Model severity - Minor Bug and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Sep 9, 2022
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 15, 2022

Could you supply a (ideally minimum, complete, verifiable) example of your code that highlight the bug please?

I've tested a simple clone of the CoilCoolingDXMultiSpeed (not via AirLoopHVAC) and it's already wrong but a different kind of wrong than yours: the stages aren't blank, they are duplicated....

include OpenStudio::Model

m = Model.new

cc = CoilCoolingDXMultiSpeed.new(m)
stage1 = CoilCoolingDXMultiSpeedStageData.new(m)
stage2 = CoilCoolingDXMultiSpeedStageData.new(m)
cc.setStages([stage1, stage2])
puts "cc has #{cc.numberOfStages} stages: #{cc.stages.map{|c| c.nameString}}"
=> cc has 2 stages: ["Coil Cooling DX Multi Speed Stage Data 1", "Coil Cooling DX Multi Speed Stage Data 2"]

cc2 = cc.clone(m).to_CoilCoolingDXMultiSpeed.get
[utilities.idf.Workspace] <-1> Renamed Object of type 'OS:Coil:Cooling:DX:MultiSpeed' and named 'Coil Cooling DX Multi Speed 1' to 'Coil Cooling DX Multi Speed 2' to avoid a name conflict upon WorkspaceObject addition.
[utilities.idf.Workspace] <-1> Renamed Object of type 'OS:Coil:Cooling:DX:MultiSpeed:StageData' and named 'Coil Cooling DX Multi Speed Stage Data 1' to 'Coil Cooling DX Multi Speed Stage Data 3' to avoid a name conflict upon WorkspaceObject addition.
[utilities.idf.Workspace] <-1> Renamed Object of type 'OS:Coil:Cooling:DX:MultiSpeed:StageData' and named 'Coil Cooling DX Multi Speed Stage Data 2' to 'Coil Cooling DX Multi Speed Stage Data 4' to avoid a name conflict upon WorkspaceObject addition.
puts "cc2 has #{cc2.numberOfStages} stages: #{cc2.stages.map{|c| c.nameString}}"
=> cc2 has 4 stages: ["Coil Cooling DX Multi Speed Stage Data 1", "Coil Cooling DX Multi Speed Stage Data 2", "Coil Cooling DX Multi Speed Stage Data 3", "Coil Cooling DX Multi Speed Stage Data 4"]

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 23, 2022

@mleachNREL Could you let me know if you had a different error please? I've opened #4683 which is ready to merge, but I'd like to make sure I addressed your actual issue and not another one. Thanks!

jmarrec added a commit that referenced this issue Sep 26, 2022
jmarrec added a commit that referenced this issue Sep 28, 2022
#4663 #4664 - Fix CoilCoolingDXMultiSpeed::clone and extend testing for AirLoopHVAC::clone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants