Modify Model::load(path&) to use VersionTranslator by default

[jmarrec]

Enhancement Request

It's been like this for ever, but it's weird that Model::load just assumes this is at the right version. It's very confusing to new users too, and they struggle with knowing how to load a model.

OpenStudio/src/model/Model.cpp

Lines 1836 to 1858 in 92da27b

	boost::optional<Model> Model::load(const path& osmPath) {
	OptionalModel result;
	OptionalIdfFile oIdfFile = IdfFile::load(osmPath, IddFileType::OpenStudio);
	if (oIdfFile) {
	try {
	result = Model(*oIdfFile);
	} catch (...) {
	}
	}
	if (result) {
	// Load the workflow.osw in the model's companion folder
	path workflowJSONPath = getCompanionFolder(osmPath) / toPath("workflow.osw");
	if (exists(workflowJSONPath)) {
	boost::optional<WorkflowJSON> workflowJSON = WorkflowJSON::load(workflowJSONPath);
	if (workflowJSON) {
	result->setWorkflowJSON(*workflowJSON);
	}
	}
	}
	return result;
	}

It shouldn't be that verbose to load a model

https://github.com/NREL/OpenStudio-workflow-gem/blob/cf99e6096f33b717df79a71c245a4d7aa4ccb7a6/lib/openstudio/workflow/util/model.rb#L51-L70

Detailed Description

At the very least we should provide an override or extra bool parameter.

Possible Implementation

Straightforward

[kbenne]

Two thumbs up for this. So annoying to version translate first. Love this issue.

[DavidGoldwasser]

Here is how model is loaded in measure tests
https://github.com/NREL/openstudio-common-measures-gem/blob/develop/lib/measures/ChangeBuildingLocation/tests/change_building_location_test.rb#L39-43