Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS:ComponentData #4767

Closed
tijcolem opened this issue Dec 19, 2022 · 0 comments
Closed

OS:ComponentData #4767

tijcolem opened this issue Dec 19, 2022 · 0 comments

Comments

@tijcolem
Copy link
Collaborator

When running measure https://github.com/NREL/openstudio-aedg-gem/blob/develop/lib/measures/zedgk_12_hvac_vrf_with_doas/measure.rb with 3.5.1-rc1, it fails with the following error.

  1. Error:
    ZEDGVRFWithDOAS_Test#test_ZEDGVRFWithDOAS:
    NoMethodError: undefined method regsiterError' for #<OpenStudio::Measure::OSRunner:0x00007f86d952b298> /Users/tcoleman/git/openstudio-aedg-gem/lib/measures/zedgk_12_hvac_vrf_with_doas/measure.rb:344:in block in run'
    /Users/tcoleman/git/openstudio-aedg-gem/lib/measures/zedgk_12_hvac_vrf_with_doas/measure.rb:305:in each' /Users/tcoleman/git/openstudio-aedg-gem/lib/measures/zedgk_12_hvac_vrf_with_doas/measure.rb:305:in run'
    /Users/tcoleman/git/openstudio-aedg-gem/lib/measures/zedgk_12_hvac_vrf_with_doas/tests/measure_Test.rb:80:in `test_ZEDGVRFWithDOAS'

This measure loads a component .osc file and inserts the component in the model. https://github.com/NREL/openstudio-aedg-gem/blob/develop/lib/measures/zedgk_12_hvac_vrf_with_doas/measure.rb#L324

Then when attempting to accessing the primary object (https://github.com/NREL/openstudio-aedg-gem/blob/develop/lib/measures/zedgk_12_hvac_vrf_with_doas/measure.rb#L329) it returns a different object than what is expected. In this example, it returns:

Primary Object
OS:Table:IndependentVariable,
{05a9af82-2608-4a26-a1f8-7f5b4541bd4c}, !- Handle

Perhaps the new method that was introduced (https://github.com/NREL/OpenStudio/pull/4757/files#diff-6cef0026841f3838a343f32c9b76a5c7fb15a31a0630fa57a5a0c5d116d6c015R656-R690) might not order the data in OS:ComponentData correctly?

@tijcolem tijcolem added Triage Issue needs to be assessed and labeled, further information on reported might be needed severity - Normal Bug component - Model and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Dec 19, 2022
jmarrec added a commit that referenced this issue Dec 19, 2022
tijcolem added a commit that referenced this issue Dec 19, 2022
Fix #4767 - Preserve order of Component objects during VersionTranslation
@jmarrec jmarrec closed this as completed Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants