Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to EnergyPlus 24.1.0 #5090

Closed
11 of 13 tasks
joseph-robertson opened this issue Feb 15, 2024 · 1 comment · Fixed by #5094
Closed
11 of 13 tasks

Update to EnergyPlus 24.1.0 #5090

joseph-robertson opened this issue Feb 15, 2024 · 1 comment · Fixed by #5094

Comments

@joseph-robertson
Copy link
Collaborator

joseph-robertson commented Feb 15, 2024

Enhancement Request

Once v24.1-IOFreeze is released, we should update to it.

Detailed Description

https://github.com/NREL/EnergyPlus/blob/develop/src/Transition/InputRulesFiles/Rules23-2-0-to-24-1-0.md
https://github.com/NREL/EnergyPlus/blob/develop/src/Transition/OutputRulesFiles/OutputChanges23-2-0-to-24-1-0.md

Major changes

New additions

Minor stuff

Other

  • ComfortViewFactorAngles: remove "Zone Name" field
    • Appears this isn't wrapped; no OS change required?
  • AirflowNetwork:Distribution:Component:Coil: field "Coil Object Type" has new keys
    • Appears this isn't wrapped; no OS change required?
  • ZoneHVAC:ForcedAir:UserDefined, AirTerminal:SingleDuct:UserDefined, Coil:UserDefined, PlantComponent:UserDefined: extra notes
@joseph-robertson joseph-robertson added this to the OpenStudio SDK 3.8.0 milestone Feb 15, 2024
@joseph-robertson joseph-robertson added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. and removed Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Feb 22, 2024
@jmarrec
Copy link
Collaborator

jmarrec commented Mar 11, 2024

Why is ElectricEquipment:ITE:AirCooled still "Watts per Zone Floor Area" in OS idd?

OS:ElectricEquipment:ITE:AirCooled:Definition,
  N2 , \field Watts per Zone Floor Area

All of the other SpaceLoadDefinition objects (Lights:Definition, ElectricEquipment:Definition, etc) have

  N2, \field Watts per Space Floor Area

No-one really noticed and bothered to change it probably. It's been like this for ever (6 years, when the object was wrapped: https://github.com/NREL/OpenStudio/blame/develop/src/model/ElectricEquipmentITEAirCooledDefinition.hpp#L68 , and that was before the Space was a thing in E+)

(Also, this object is weird in the sense that it's a SpaceLoadInstance, but it's an HVAC component, which is more a zonal thing than a space one to me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants